* [PATCH 1/2] net/nfb: remove unused flag
@ 2026-01-01 18:13 Stephen Hemminger
2026-01-01 18:13 ` [PATCH 2/2] net/af_packet: remove unused attribute Stephen Hemminger
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Stephen Hemminger @ 2026-01-01 18:13 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Martin Spinler
The configure callback does use the device argument.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/nfb/nfb_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c
index 98119d70fd..5f1b11a961 100644
--- a/drivers/net/nfb/nfb_ethdev.c
+++ b/drivers/net/nfb/nfb_ethdev.c
@@ -181,7 +181,7 @@ nfb_eth_dev_stop(struct rte_eth_dev *dev)
* 0 on success, a negative errno value otherwise.
*/
static int
-nfb_eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
+nfb_eth_dev_configure(struct rte_eth_dev *dev)
{
int ret;
struct pmd_internals *internals = dev->data->dev_private;
--
2.51.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 2/2] net/af_packet: remove unused attribute
2026-01-01 18:13 [PATCH 1/2] net/nfb: remove unused flag Stephen Hemminger
@ 2026-01-01 18:13 ` Stephen Hemminger
2026-01-12 1:14 ` Stephen Hemminger
2026-01-12 1:14 ` [PATCH 1/2] net/nfb: remove unused flag Stephen Hemminger
2026-01-12 6:17 ` Martin Spinler
2 siblings, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2026-01-01 18:13 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, John W. Linville
The device configure callback does use the device argument.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/af_packet/rte_eth_af_packet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
index ef11b8fb6b..c0ba3381ea 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -374,7 +374,7 @@ eth_dev_stop(struct rte_eth_dev *dev)
}
static int
-eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
+eth_dev_configure(struct rte_eth_dev *dev)
{
struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
const struct rte_eth_rxmode *rxmode = &dev_conf->rxmode;
--
2.51.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] net/nfb: remove unused flag
2026-01-01 18:13 [PATCH 1/2] net/nfb: remove unused flag Stephen Hemminger
2026-01-01 18:13 ` [PATCH 2/2] net/af_packet: remove unused attribute Stephen Hemminger
@ 2026-01-12 1:14 ` Stephen Hemminger
2026-01-12 6:17 ` Martin Spinler
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2026-01-12 1:14 UTC (permalink / raw)
To: dev; +Cc: Martin Spinler
On Thu, 1 Jan 2026 10:13:43 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:
> The configure callback does use the device argument.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/nfb/nfb_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c
> index 98119d70fd..5f1b11a961 100644
> --- a/drivers/net/nfb/nfb_ethdev.c
> +++ b/drivers/net/nfb/nfb_ethdev.c
> @@ -181,7 +181,7 @@ nfb_eth_dev_stop(struct rte_eth_dev *dev)
> * 0 on success, a negative errno value otherwise.
> */
> static int
> -nfb_eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
> +nfb_eth_dev_configure(struct rte_eth_dev *dev)
> {
> int ret;
> struct pmd_internals *internals = dev->data->dev_private;
Queued to next-net
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] net/nfb: remove unused flag
2026-01-01 18:13 [PATCH 1/2] net/nfb: remove unused flag Stephen Hemminger
2026-01-01 18:13 ` [PATCH 2/2] net/af_packet: remove unused attribute Stephen Hemminger
2026-01-12 1:14 ` [PATCH 1/2] net/nfb: remove unused flag Stephen Hemminger
@ 2026-01-12 6:17 ` Martin Spinler
2 siblings, 0 replies; 5+ messages in thread
From: Martin Spinler @ 2026-01-12 6:17 UTC (permalink / raw)
To: dev
Acked-by: Martin Spinler <spinler@cesnet.cz>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-01-12 6:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-01 18:13 [PATCH 1/2] net/nfb: remove unused flag Stephen Hemminger
2026-01-01 18:13 ` [PATCH 2/2] net/af_packet: remove unused attribute Stephen Hemminger
2026-01-12 1:14 ` Stephen Hemminger
2026-01-12 1:14 ` [PATCH 1/2] net/nfb: remove unused flag Stephen Hemminger
2026-01-12 6:17 ` Martin Spinler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).