From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v3 2/3] test: allow larger packet sizes
Date: Sat, 10 Jan 2026 09:21:32 -0800 [thread overview]
Message-ID: <20260110092132.729f93b8@phoenix.local> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35F6563A@smartserver.smartshare.dk>
On Fri, 9 Jan 2026 16:00:00 +0100
Morten Brørup <mb@smartsharesystems.com> wrote:
> > generate_packet_burst(struct rte_mempool *mp, struct rte_mbuf
> > **pkts_burst,
> > struct rte_ether_hdr *eth_hdr, uint8_t vlan_enabled,
> > void *ip_hdr, uint8_t ipv4, struct rte_udp_hdr *udp_hdr,
> > - int nb_pkt_per_burst, uint8_t pkt_len, uint8_t
> > nb_pkt_segs);
> > + int nb_pkt_per_burst, uint16_t pkt_len, uint8_t
> > nb_pkt_segs);
>
> The pkt_len field in rte_mbuf is uint32_t.
> You could upgrade the packet length here to uint32_t too, instead of upgrading to only uint16_t.
This code is generating UDP packets, and the maximum size allowed with UDP is UINT16_MAX.
IP packet length is also limited to 16 bits.
But you comment did motivate fixing to allow more packet segments.
next prev parent reply other threads:[~2026-01-10 17:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 22:25 [PATCH] test: add a test for null PMD Stephen Hemminger
2026-01-05 14:49 ` Marat Khalili
2026-01-05 17:38 ` Stephen Hemminger
2026-01-06 16:47 ` [PATCH v2 0/2] net/null: add a test Stephen Hemminger
2026-01-06 16:47 ` [PATCH v2 1/2] test: add a test for null PMD Stephen Hemminger
2026-01-06 17:40 ` Marat Khalili
2026-01-06 18:01 ` Stephen Hemminger
2026-01-06 16:47 ` [PATCH v2 2/2] net/null: revise info_get Stephen Hemminger
2026-01-08 20:40 ` [PATCH v3 0/3] test: new test for null PMD Stephen Hemminger
2026-01-08 20:40 ` [PATCH v3 1/3] net/null: cleanup info_get Stephen Hemminger
2026-01-08 20:40 ` [PATCH v3 2/3] test: allow larger packet sizes Stephen Hemminger
2026-01-09 15:00 ` Morten Brørup
2026-01-10 17:21 ` Stephen Hemminger [this message]
2026-01-08 20:40 ` [PATCH v3 3/3] test: add a test for null PMD Stephen Hemminger
2026-01-09 1:21 ` Stephen Hemminger
2026-01-10 17:22 ` [PATCH v4 0/3] null pmd minor cleanup and add test Stephen Hemminger
2026-01-10 17:22 ` [PATCH v4 1/3] net/null: cleanup info_get Stephen Hemminger
2026-01-10 17:22 ` [PATCH v4 2/3] test: generate larger packet bursts Stephen Hemminger
2026-01-10 17:22 ` [PATCH v4 3/3] test: add a test for null PMD Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260110092132.729f93b8@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).