DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Marat Khalili <marat.khalili@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [RFC] doc: add AGENTS.md for AI-powered code review tools
Date: Sat, 10 Jan 2026 09:28:16 -0800	[thread overview]
Message-ID: <20260110092816.75c398aa@phoenix.local> (raw)
In-Reply-To: <bc4a13bebde740adb57e80c5156f3cde@huawei.com>

On Fri, 9 Jan 2026 09:58:38 +0000
Marat Khalili <marat.khalili@huawei.com> wrote:

> In my very limited experience it helps to tell the model that all commits (both 
> patch and commit message) MUST pass devtools/checkpatches.sh, ideally 
> configured (and verified) as a git hook, clear justification must be 
> provided in rare exception cases.

Models don't really run scripts. Would like the auto code review tools
to do a better job of pre-parsing for checkpatch rules and explaining better.



> From the general programming principles I'm unsure about duplicating 
> information already available in doc/guides/contributing in the same tree. 
> Perhaps we could just instruct the model to read patches.rst and 
> coding_style.rst, they are not very big (and models typically know Linux and 
> PIP8 rules already). Otherwise we risk one of the documents becoming outdated, 
> or rules/nuances omitted in the summarized version ignored. In instructions 
> specifically for the model we could focus on things that are persistent source 
> of problems for it despite instructions for humans being clear.
> 
> Just my 2c, great that someone is working on this.

I am not sure that models will always interpret our documentation the same
and this looks clearer. Also, there is lots of overlap with other projects
which is not covered in DPDK alone.

  reply	other threads:[~2026-01-10 17:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09  1:41 Stephen Hemminger
2026-01-09  9:46 ` Bruce Richardson
2026-01-10 17:34   ` Stephen Hemminger
2026-01-09  9:58 ` Marat Khalili
2026-01-10 17:28   ` Stephen Hemminger [this message]
2026-01-10 18:00 ` [RFC v2] " Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260110092816.75c398aa@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=marat.khalili@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).