From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id A814298 for ; Mon, 9 Jan 2017 14:19:00 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id k184so119329370wme.1 for ; Mon, 09 Jan 2017 05:19:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=AObIikQPVQapTsZF9c4+u1nBXFlQGwTFPqKsQgs3k9A=; b=JCo3DB9z5eoBP4lOIHpZUBtS3wznskAl2OmCvr+O2KuTFYh8PWh4SEUJLuFmebAr8N x/HNfWkyit6z7AXon4UgskAgopRNFT4OE6qw07kjbcUICMh4XF7YM6euIq3MNC8mJXcR cmAlB/T+nnhKXwEeToSIOe9VH5mhQhJ7LQ7QE9ZZff1ffcROOaYi+AEknMBWJnf8RLKg ruOuxnT1LX6hR2WXSHpq0jXBQKva4V5eQqXFCHDdMx8blpFzr4OuliCbtr4oD5050tfd tSXrB1w5V3d4GU21AxKAozo2X/2n77+418mAEEJd4nulK7SBm2K0Sxi2r7DXarpYIKSF 2jFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=AObIikQPVQapTsZF9c4+u1nBXFlQGwTFPqKsQgs3k9A=; b=M2/vanapsKJZXt2Z2xYdS789Xo929ZGFgEsXccxuYe9W7wFEzQOVKksEK+jCRoB+pT j9ojJMoULI/UzK4Iz8PXPCc5nAgSnvZaYwof6g0Txafjb6GpNfZiHxP0J5XIPqqg/Tqv SyAOsJ2qALLgeAFJPr8oyYzULvtrwsNrYpkB/ijDaDR3mceojfaN9oqF4uY61ggzvjCn 30jBuGTepKObR22W61fVovhStFV9Yxty5MQpTyfRV2Nv+L7YEy4X8B/vHKealOE+z9L3 QCj5QHqYQQiCYBnLcLS5h6qhDFEl8/u9zVLxpsLKRzOEOMIdzcGCb6wpLpNrAytkVu0e m03g== X-Gm-Message-State: AIkVDXJ8n7Xi2AVaWEc2pLlKptEyqw/I26MPsRhS1+lsWoxNLJ8BeKSEynRY02Zm/Z4jZ91S X-Received: by 10.28.4.216 with SMTP id 207mr4224886wme.45.1483967940449; Mon, 09 Jan 2017 05:19:00 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id l67sm18772630wmf.20.2017.01.09.05.18.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2017 05:18:59 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Cc: Bruce Richardson , "Wu, Jingjing" , Michal Miroslaw , "Yigit, Ferruh" Date: Mon, 09 Jan 2017 14:18:58 +0100 Message-ID: <2026939.L9sH03DzKe@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170109120255.GA86544@bricha3-MOBL3.ger.corp.intel.com> References: <9BB6961774997848B5B42BEC655768F810CC0197@SHSMSX103.ccr.corp.intel.com> <20170109120255.GA86544@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 13:19:00 -0000 2017-01-09 12:02, Bruce Richardson: > On Wed, Dec 28, 2016 at 03:51:56AM +0000, Wu, Jingjing wrote: > >=20 > >=20 > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michal Miros= law > > > Sent: Tuesday, December 13, 2016 9:08 AM > > > To: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH 13/13] i40e: improve message grepabili= ty > > >=20 > > > Signed-off-by: Micha=C5=82 Miros=C5=82aw > > > --- > > > drivers/net/i40e/i40e_ethdev.c | 198 +++++++++++++++------------= -------------- > > > 1 file changed, 73 insertions(+), 125 deletions(-) > > >=20 > > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i4= 0e_ethdev.c > > > index 39fbcfe..4d73aca 100644 > > > --- a/drivers/net/i40e/i40e_ethdev.c > > > +++ b/drivers/net/i40e/i40e_ethdev.c > > > @@ -763,8 +763,7 @@ i40e_add_tx_flow_control_drop_filter(struct i= 40e_pf > > > *pf) > > > =09=09=09=09pf->main_vsi_seid, 0, > > > =09=09=09=09TRUE, NULL, NULL); > > > =09if (ret) > > > -=09=09PMD_INIT_LOG(ERR, "Failed to add filter to drop flow contr= ol " > > > -=09=09=09=09 " frames from VSIs."); > > > +=09=09PMD_INIT_LOG(ERR, "Failed to add filter to drop flow contr= ol > > > frames > > > +from VSIs."); > > > } > >=20 > > You are right, it makes grep easily. But it will break the coding s= tyle "Line length is recommended to be not more than 80 characters, inc= luding comments." > >=20 > > Any comments from committers? > >=20 > Being able to grep error messages is more important that having lines= > wrapped at 80 characters. I believe checkpatch ignores long strings w= hen > checking line lengths. I agree keeping strings is more important than checkpatch conformity. Please, if checkpatch complains, try to tune the script checkpatch.sh. There are some options to manage strings.