[dpdk-dev] [PATCH v1] examples/multi_process: fix build error

[dpdk-dev] [PATCH v1] examples/multi_process: fix build error

[Emma Kenny]

Fix bug with undeclared variable name and
calling a variable that is not member of struct.

CC main.o
l2fwd_fork/main.c:  In function ‘main’: l2fwd_fork/main.c:1043:33:
 error: ‘dev_info’ undeclared (first use in this function)
 rte_eth_dev_info_get(portid, &dev_info);

l2fwd_fork/main.c:1043:33: note: each undeclared identifier is
reported only once for each function it appears in
l2fwd_fork/main.c:1077:11: error: ‘struct rte_eth_txconf’
has no member named ‘tx_offloads’
   txq_conf.tx_offloads = local_port_conf.txmode.offloads;

make[1]: *** [main.o] Error 1
make: *** [all] Error 2

Fixes: f8c02ca878af ("examples/multi_process: convert to new ethdev offloads API")
Cc: shahafs@mellanox.com

Signed-off-by: Emma Kenny <emma.kenny@intel.com>
---
 examples/multi_process/l2fwd_fork/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/examples/multi_process/l2fwd_fork/main.c b/examples/multi_process/l2fwd_fork/main.c
index 94318ab..62e3937 100644
--- a/examples/multi_process/l2fwd_fork/main.c
+++ b/examples/multi_process/l2fwd_fork/main.c
@@ -1030,6 +1030,7 @@ main(int argc, char **argv)
 		struct rte_eth_rxconf rxq_conf;
 		struct rte_eth_txconf txq_conf;
 		struct rte_eth_conf local_port_conf = port_conf;
+		struct rte_eth_dev_info dev_info;
 
 		/* skip ports that are not enabled */
 		if ((l2fwd_enabled_port_mask & (1 << portid)) == 0) {
@@ -1074,7 +1075,7 @@ main(int argc, char **argv)
 		fflush(stdout);
 		txq_conf = dev_info.default_txconf;
 		txq_conf.txq_flags = ETH_TXQ_FLAGS_IGNORE;
-		txq_conf.tx_offloads = local_port_conf.txmode.offloads;
+		txq_conf.offloads = local_port_conf.txmode.offloads;
 		ret = rte_eth_tx_queue_setup(portid, 0, nb_txd,
 				rte_eth_dev_socket_id(portid),
 				&txq_conf);
-- 
2.9.5

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.

Re: [dpdk-dev] [PATCH v1] examples/multi_process: fix build error

[Ferruh Yigit]

On 7/2/2018 4:40 PM, Emma Kenny wrote:
> Fix bug with undeclared variable name and
> calling a variable that is not member of struct.
> 
> CC main.o
> l2fwd_fork/main.c:  In function ‘main’: l2fwd_fork/main.c:1043:33:
>  error: ‘dev_info’ undeclared (first use in this function)
>  rte_eth_dev_info_get(portid, &dev_info);
> 
> l2fwd_fork/main.c:1043:33: note: each undeclared identifier is
> reported only once for each function it appears in
> l2fwd_fork/main.c:1077:11: error: ‘struct rte_eth_txconf’
> has no member named ‘tx_offloads’
>    txq_conf.tx_offloads = local_port_conf.txmode.offloads;
> 
> make[1]: *** [main.o] Error 1
> make: *** [all] Error 2
> 
> Fixes: f8c02ca878af ("examples/multi_process: convert to new ethdev offloads API")
> Cc: shahafs@mellanox.com
> 
> Signed-off-by: Emma Kenny <emma.kenny@intel.com>

Cc: stable@dpdk.org

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [PATCH v1] examples/multi_process: fix build error

[Shahaf Shuler]

Monday, July 2, 2018 6:40 PM, Emma Kenny:
> Subject: [PATCH v1] examples/multi_process: fix build error
> 
> Fix bug with undeclared variable name and calling a variable that is not
> member of struct.
> 
> CC main.o
> l2fwd_fork/main.c:  In function ‘main’: l2fwd_fork/main.c:1043:33:
>  error: ‘dev_info’ undeclared (first use in this function)
> rte_eth_dev_info_get(portid, &dev_info);
> 
> l2fwd_fork/main.c:1043:33: note: each undeclared identifier is reported only
> once for each function it appears in
> l2fwd_fork/main.c:1077:11: error: ‘struct rte_eth_txconf’
> has no member named ‘tx_offloads’
>    txq_conf.tx_offloads = local_port_conf.txmode.offloads;
> 
> make[1]: *** [main.o] Error 1
> make: *** [all] Error 2
> 
> Fixes: f8c02ca878af ("examples/multi_process: convert to new ethdev
> offloads API")
> Cc: shahafs@mellanox.com
> 
> Signed-off-by: Emma Kenny <emma.kenny@intel.com>

Acked-by: Shahaf Shuler <shahafs@mellanox.com>

> ---
>  examples/multi_process/l2fwd_fork/main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/examples/multi_process/l2fwd_fork/main.c
> b/examples/multi_process/l2fwd_fork/main.c
> index 94318ab..62e3937 100644
> --- a/examples/multi_process/l2fwd_fork/main.c
> +++ b/examples/multi_process/l2fwd_fork/main.c
> @@ -1030,6 +1030,7 @@ main(int argc, char **argv)
>  		struct rte_eth_rxconf rxq_conf;
>  		struct rte_eth_txconf txq_conf;
>  		struct rte_eth_conf local_port_conf = port_conf;
> +		struct rte_eth_dev_info dev_info;
> 
>  		/* skip ports that are not enabled */
>  		if ((l2fwd_enabled_port_mask & (1 << portid)) == 0) { @@ -
> 1074,7 +1075,7 @@ main(int argc, char **argv)
>  		fflush(stdout);
>  		txq_conf = dev_info.default_txconf;
>  		txq_conf.txq_flags = ETH_TXQ_FLAGS_IGNORE;
> -		txq_conf.tx_offloads = local_port_conf.txmode.offloads;
> +		txq_conf.offloads = local_port_conf.txmode.offloads;
>  		ret = rte_eth_tx_queue_setup(portid, 0, nb_txd,
>  				rte_eth_dev_socket_id(portid),
>  				&txq_conf);
> --
> 2.9.5
> 
> --------------------------------------------------------------
> Intel Research and Development Ireland Limited Registered in Ireland
> Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
> Registered Number: 308263
> 
> 
> This e-mail and any attachments may contain confidential material for the
> sole use of the intended recipient(s). Any review or distribution by others is
> strictly prohibited. If you are not the intended recipient, please contact the
> sender and delete all copies.

Re: [dpdk-dev] [PATCH v1] examples/multi_process: fix build error

[Thomas Monjalon]

03/07/2018 14:10, Shahaf Shuler:
> Monday, July 2, 2018 6:40 PM, Emma Kenny:
> > Subject: [PATCH v1] examples/multi_process: fix build error
> > 
> > Fix bug with undeclared variable name and calling a variable that is not
> > member of struct.
> > 
> > CC main.o
> > l2fwd_fork/main.c:  In function ‘main’: l2fwd_fork/main.c:1043:33:
> >  error: ‘dev_info’ undeclared (first use in this function)
> > rte_eth_dev_info_get(portid, &dev_info);
> > 
> > l2fwd_fork/main.c:1043:33: note: each undeclared identifier is reported only
> > once for each function it appears in
> > l2fwd_fork/main.c:1077:11: error: ‘struct rte_eth_txconf’
> > has no member named ‘tx_offloads’
> >    txq_conf.tx_offloads = local_port_conf.txmode.offloads;
> > 
> > make[1]: *** [main.o] Error 1
> > make: *** [all] Error 2
> > 
> > Fixes: f8c02ca878af ("examples/multi_process: convert to new ethdev
> > offloads API")
> > Cc: shahafs@mellanox.com
> > 
> > Signed-off-by: Emma Kenny <emma.kenny@intel.com>
> 
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>

Applied, thanks