From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id EB0715683 for ; Mon, 13 Jul 2015 13:18:13 +0200 (CEST) Received: by wgmn9 with SMTP id n9so40258632wgm.0 for ; Mon, 13 Jul 2015 04:18:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=G10e4QX8z/KYYCHS3VramTh2/IMuo2CCGbCcv2Zroq0=; b=h+WWYfVIUtZIGhohLQcpD5nEu2eMRq5jqcxY1xbpwm+5D5vGp+yev1RD6aWWtv9fn3 jArNTodsJYPAtBSLUhD0cQNw6OwynDj1tVp5r+fNbuDZYITG8SEFuLkbMiNCSpOfwCre 0XzsWucsIMxw5q+o5tc4B73KDjtc1883J8/DOI6b/kJSQ/uHy1kBGS5i2S2PYeJ+bcAB SRZJBTsf0Tqc5VlQXFAIZbnvSeDWdhfrES1pllY8lkuhVI6ImNKOweiNHTs3OATczof3 iHWi3NAEqsBcwJfmx7umAEwB6v5gr0FqlOqTjOO7XHsZDuFaoc/ld0AfkAK8TNBf12Qh zhOA== X-Gm-Message-State: ALoCoQlZiNj4sqJJ/BsaGoMDmJcM0js92k3kkzln8kt9N1rG5RnrKjm904ZfcqPzwoKiHCxwhpAx X-Received: by 10.180.206.229 with SMTP id lr5mr21709273wic.86.1436786293826; Mon, 13 Jul 2015 04:18:13 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id q4sm28617487wju.14.2015.07.13.04.18.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2015 04:18:13 -0700 (PDT) Date: Mon, 13 Jul 2015 04:18:13 -0700 (PDT) X-Google-Original-Date: Mon, 13 Jul 2015 13:17 +0200 From: Thomas Monjalon To: Tomasz Kulasek Message-ID: <2027479.0yqGHXrX1o@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1604538.YavAJG9xMg@xps13> References: <1434723200-7528-1-git-send-email-tomaszx.kulasek@intel.com> <5593BB53.2060204@intel.com> <1604538.YavAJG9xMg@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 0/8] Dynamic RSS Configuration for Bonding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2015 11:18:14 -0000 2015-07-13 13:03, Thomas Monjalon: > 2015-07-01 11:05, Declan Doherty: > > On 29/06/15 15:50, Tomasz Kulasek wrote: > > > OVERVIEW > > > -------- > > > 1) Setting .rxmode.mq_mode for bonding device to ETH_MQ_RX_RSS makes bonding > > > device fully RSS-capable, so all slaves are synchronized with its configuration. > > > This mode is intended to provide RSS configuration as known from "dynamic RSS > > > configuration for one port" and made slaves transparent for client application > > > implementation. > > > > > > 2) If .rxmode.mq_mode for bonding device isn't ETH_MQ_RX_RSS, slaves are not > > > synchronized. That provides an ability to configure them manually. This mode may > > > be useful when application wants to manage RSS in an unusual way and the > > > consistency of RSS configuration for slaves isn't required. > > > > > > Turning on/off RSS mode for slaves when bonding is started is not possible. > > > Other RSS configuration is propagated over slaves, when bonding device API is > > > used to do it. > > > > > > v3 changes: > > > - checkpatch cleanups > > ... > > > > Acked-by : Declan Doherty > > Applied without patches 5 and 6: Sorry, after more review, this series won't be pushed at all. There is an obvious error in patch 4, and patch 2/3 must be discussed. > - As discussed earlier, patch 5 workaround a missing flag to announce stats > per queue availability. > > - Patch 6 introduce a new dependency (ncurses) to build a new bond_rss example. > Examples are useful to show how to use some features. Maybe you can show > bonding RSS in the existing bonding example without adding bells and whistles. > The example directory must be kept reasonnably maintainable.