DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Vitaliy Mysak <vitaliy.mysak@intel.com>,
	Tiwei Bie <tiwei.bie@intel.com>,
	 Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] rte_vhost: do not treat empty socket message as error
Date: Wed, 5 Feb 2020 10:47:21 +0100	[thread overview]
Message-ID: <2027f9e5-ccc5-25e1-0213-5751e34832a1@redhat.com> (raw)
In-Reply-To: <20200130080540.7616-1-vitaliy.mysak@intel.com>



On 1/30/20 9:05 AM, Vitaliy Mysak wrote:
> According to recvmsg() specification, 0 is a valid
> return code when client is disconnecting.
> Therefore, it should not be reported as error, unless there
> are other dependencies that require message to not be empty.
> But there are none, since the next immediate caller of recvmsg()
> reports "vhost peer closed" info (not error) when message is empty.
> 
> This patch changes return code check for recvmsg() so that
> misleading error message is not printed when the code is 0.
> 
> Signed-off-by: Vitaliy Mysak <vitaliy.mysak@intel.com>
> ---
>  lib/librte_vhost/socket.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied to dpdk-next-virtio tree.

Thanks,
Maxime


  parent reply	other threads:[~2020-02-05  9:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30  8:05 Vitaliy Mysak
2020-02-05  5:08 ` Tiwei Bie
2020-02-05  9:47 ` Maxime Coquelin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-01-29  9:22 Vitaliy Mysak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2027f9e5-ccc5-25e1-0213-5751e34832a1@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=tiwei.bie@intel.com \
    --cc=vitaliy.mysak@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).