From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1358A0A0C; Sat, 10 Jul 2021 08:44:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89A2140DDB; Sat, 10 Jul 2021 08:44:00 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id AC509407FF for ; Sat, 10 Jul 2021 08:43:59 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id B12F53200E93; Sat, 10 Jul 2021 02:43:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 10 Jul 2021 02:43:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= eftNqUkoCW1TI31HKRHmpLkOWwE+h6vuiwrVJumACv4=; b=2CXJEksdUeT/xett yMQ7dSTaipNyOb8yq+gE7XA+3HlEefsst4BDzTrXhn/LnA6inon2Y27BX46tsa3T zXmR2siHo0TvLjwWEOLaf4UlVlkk1cvY/Hb359Rzsw75Ry8x0uDxDLWdNWfpmi6P ZehN1Xi7RkqlQU1iDGrSCtoERYDDUObzOmLofxQyNbYrnUS8CJX6TC6tTnvuy0AG jV/k00wLNUCvQ4zvzJqc8r0eao0O5Nh0qZ7yLZafq2J2pTAVonxkVe/QkuOzGPtt E/zRKJG+OYIg7hc83b2pY+bFSNiPQW528WNxxM+XRmwr8sViYyZVcS7rO6HCeQpB hnsi+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=eftNqUkoCW1TI31HKRHmpLkOWwE+h6vuiwrVJumAC v4=; b=rmA7GkI4/wGu5KafAdK4uXVv3zJwv3tfukpwpW0ci8UOAh7FIv4tD7B18 b05kg2UXNkn2qD5mUOIIVGgR3gWQJcfIgTZCzOLr8gamO2JCWRFvynefKztP07g8 wzDk8KyQX+c5+Fqxu0HyC0rmrOiLJhuoz1xq7JRjgfrkTBmP/MjnR0l/mapRMfNu fmW7Hw/g8TNy7npdmEKVxBYafplmomghXPnD5xS3X/H3CS48jmzu6m5vdi8tZckr RyNn4MbYpQ27yLVWsS35p1BuGxgAI+S0Qha4eMUSvvqs9Ewn6+UGBIUMi/hOS6cm kKPd806TF82jKrHWuYZFOyjUxO86A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrtdejgdeludcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 10 Jul 2021 02:43:57 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, "Burakov, Anatoly" Date: Sat, 10 Jul 2021 08:43:55 +0200 Message-ID: <2029301.lu3ZZSHYa3@thomas> In-Reply-To: References: <20210531113008.3087-1-david.hunt@intel.com> <2c7d7f4d-bf2b-7698-53ee-b8133d8013cb@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/06/2021 16:14, Burakov, Anatoly: > On 23-Jun-21 1:09 PM, David Hunt wrote: > > On 23/6/2021 11:14 AM, Burakov, Anatoly wrote: > >> On 22-Jun-21 3:07 PM, David Hunt wrote: > >>> The PMD Power Management scheme currently has 3 modes, > >>> scale, monitor and pause. However, it would be nice to > >>> have a baseline mode for easy comparison of power savings > >>> with and without these modes. > >>> > >>> This patch adds a 'baseline' mode were the pmd power > >>> management is not enabled. Use --pmg-mgmt=baseline. > >>> > >>> Signed-off-by: David Hunt > >>> > >>> --- > >>> - if (app_mode == APP_MODE_PMD_MGMT) { > >>> + if ((app_mode == APP_MODE_PMD_MGMT) && > >>> + (baseline_enabled == false)) { > >> > >> Nitpicking, !baseline_enabled > >> > > Thanks, Anatoly. I don't feel a re-spin is needed for this, but I'll > > take this format into consideration for future patches, OK? > > Yep, i'm fine either way. Maybe someone can fix it on apply :) Applied with the change.