From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 8FF564F9A; Mon, 22 Apr 2019 23:20:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 0D84FE158; Mon, 22 Apr 2019 17:20:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 17:20:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=sdfLGLldFfIq0NoeyTEhUctdsG09JrTaugifuXRyIx4=; b=rW7EWXXgPNFn W6YgSpGHpHUu7dG1wwyeI0vyA9YFNV2rBTnjbzwiY0RZbfED9Xavf3aM6r+DL0y5 JU2nUxUQboKaG9rs9JWeWgalqJz6PvB2/mGn9cDv1PzoCtEfy+Y6YMS0tHWdLTAI ljTjrMkV/81V0IsXXagqmxeDFY3Jgko= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=sdfLGLldFfIq0NoeyTEhUctdsG09JrTaugifuXRyI x4=; b=P8KXVpf2JLThsA2HvNxCfsPkeBvMAD7R1CnClefxDDkAdcg5MlPTGXmFr vXJ94glIDogqzjqHrSgEd42j/eisDhbEZP9Ly7XkKpY5lIfI1Xu1VJr1TVJl+mFQ IwwKHKDlbTnmz53ir3rHDiPpKueIgUV7Blb5nFiFLM9iJmzLw0W/KUIKhefpPPuB xptzzqPqBSwHav37hgabLD3aOMG/hnEFLT3W8y3xmOG4LjlvjkzrZuXpKWXXoFt4 shJ57Q7DAgEUYje4aXSzCH/4Nv7V/FC6gvQ+gss8DOf89G2naoGLhQgWLswiTp72 VLpd651yEUJqbeIZq5eSTxUqzXt9g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeekfedrudduhedrudehhedrudefkeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id 7014B10319; Mon, 22 Apr 2019 17:20:43 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: dev@dpdk.org, Jerin Jacob Kollanukkaran , Marko Kovacevic , Ori Kam , Bruce Richardson , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , "stable@dpdk.org" Date: Mon, 22 Apr 2019 23:20:40 +0200 Message-ID: <2029347.cZ2XlDF34S@xps> In-Reply-To: <20190410072836.17496-1-pbhagavatula@marvell.com> References: <20190410072836.17496-1-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 21:20:48 -0000 10/04/2019 09:29, Pavan Nikhilesh Bhagavatula: > From: Pavan Nikhilesh > > Currently, l3wfd em mode has two datapath modes em_sequential and > em_hlm. We can select either of them by defining NO_HASH_MULTI_LOOKUP to > one or zero. > The code checks if NO_HASH_MULTI_LOOKUP is defined or not instead of > checking for the value. > > Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance") > Cc: stable@dpdk.org > > Signed-off-by: Pavan Nikhilesh > --- > --- a/examples/l3fwd/l3fwd_em.c > +++ b/examples/l3fwd/l3fwd_em.c > #if defined RTE_ARCH_X86 || defined RTE_MACHINE_CPUFLAG_NEON > -#if defined(NO_HASH_MULTI_LOOKUP) > +#if NO_HASH_MULTI_LOOKUP A quick grep shows that it used in another place with #ifdef: examples/l3fwd/l3fwd.h:#if !defined(NO_HASH_MULTI_LOOKUP) && defined(RTE_MACHINE_CPUFLAG_NEON) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 40630A05D3 for ; Mon, 22 Apr 2019 23:20:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BDDE01B42E; Mon, 22 Apr 2019 23:20:49 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 8FF564F9A; Mon, 22 Apr 2019 23:20:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 0D84FE158; Mon, 22 Apr 2019 17:20:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 17:20:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=sdfLGLldFfIq0NoeyTEhUctdsG09JrTaugifuXRyIx4=; b=rW7EWXXgPNFn W6YgSpGHpHUu7dG1wwyeI0vyA9YFNV2rBTnjbzwiY0RZbfED9Xavf3aM6r+DL0y5 JU2nUxUQboKaG9rs9JWeWgalqJz6PvB2/mGn9cDv1PzoCtEfy+Y6YMS0tHWdLTAI ljTjrMkV/81V0IsXXagqmxeDFY3Jgko= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=sdfLGLldFfIq0NoeyTEhUctdsG09JrTaugifuXRyI x4=; b=P8KXVpf2JLThsA2HvNxCfsPkeBvMAD7R1CnClefxDDkAdcg5MlPTGXmFr vXJ94glIDogqzjqHrSgEd42j/eisDhbEZP9Ly7XkKpY5lIfI1Xu1VJr1TVJl+mFQ IwwKHKDlbTnmz53ir3rHDiPpKueIgUV7Blb5nFiFLM9iJmzLw0W/KUIKhefpPPuB xptzzqPqBSwHav37hgabLD3aOMG/hnEFLT3W8y3xmOG4LjlvjkzrZuXpKWXXoFt4 shJ57Q7DAgEUYje4aXSzCH/4Nv7V/FC6gvQ+gss8DOf89G2naoGLhQgWLswiTp72 VLpd651yEUJqbeIZq5eSTxUqzXt9g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeekfedrudduhedrudehhedrudefkeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id 7014B10319; Mon, 22 Apr 2019 17:20:43 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: dev@dpdk.org, Jerin Jacob Kollanukkaran , Marko Kovacevic , Ori Kam , Bruce Richardson , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , "stable@dpdk.org" Date: Mon, 22 Apr 2019 23:20:40 +0200 Message-ID: <2029347.cZ2XlDF34S@xps> In-Reply-To: <20190410072836.17496-1-pbhagavatula@marvell.com> References: <20190410072836.17496-1-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422212040.QAWRHps98H2ZQgtGcuOIzMijryYNdXpi9F7LpOEvIuw@z> 10/04/2019 09:29, Pavan Nikhilesh Bhagavatula: > From: Pavan Nikhilesh > > Currently, l3wfd em mode has two datapath modes em_sequential and > em_hlm. We can select either of them by defining NO_HASH_MULTI_LOOKUP to > one or zero. > The code checks if NO_HASH_MULTI_LOOKUP is defined or not instead of > checking for the value. > > Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance") > Cc: stable@dpdk.org > > Signed-off-by: Pavan Nikhilesh > --- > --- a/examples/l3fwd/l3fwd_em.c > +++ b/examples/l3fwd/l3fwd_em.c > #if defined RTE_ARCH_X86 || defined RTE_MACHINE_CPUFLAG_NEON > -#if defined(NO_HASH_MULTI_LOOKUP) > +#if NO_HASH_MULTI_LOOKUP A quick grep shows that it used in another place with #ifdef: examples/l3fwd/l3fwd.h:#if !defined(NO_HASH_MULTI_LOOKUP) && defined(RTE_MACHINE_CPUFLAG_NEON)