From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7ADEB41DB5; Thu, 2 Mar 2023 14:57:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 610D940E2D; Thu, 2 Mar 2023 14:57:59 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 5998C400D6; Thu, 2 Mar 2023 14:57:58 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id BD6883200B8B; Thu, 2 Mar 2023 08:57:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 02 Mar 2023 08:57:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1677765475; x=1677851875; bh=BOE8VwmOJoKJi2GQ43CEEeaocMea81gkUDt qa+JKJtk=; b=W5MhaleW7X3qDJZXop/Vu8A7x1A8c8lnlNXT9LH5Hp4L4W21UVC rLIHnMQlqkixvdDF1fTRSyVQ5Fz+gU5EN/4K1qZOuKPIT1FXQp9fJK5e9Z+1lfCV z+lhAK0ImmJ8YB5JVljMVXdxzk0kTtGWytdMNqxco8uQ+uyvb1PcsL+e7dRzuVk0 nnsa2J5NId7ReqOMHdZG10taYBRBFynimZP4xKXSrtWYzZze7qwazLNyQCsXbdor nskn6XIVL2XNTcH/yQS2BhpZZfdLGDsw4P8MqMH46j8KomciPsgoljsw2E/VtSOI 8Ssl9K3c8kGP3l5206ihe2Zpg00iCHUOFZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1677765475; x=1677851875; bh=BOE8VwmOJoKJi2GQ43CEEeaocMea81gkUDt qa+JKJtk=; b=qyD/iF9UIBHaz+DVxyboCZT4kH/bVxabtRCMY/UitUYD5oCm6fJ O656i9vvEdjlbxi+KUmDCXYEMJ6sF0FWSJklx934/shtNni1WUpxNNqckjXYRFyo iypvkiadZXWrt5S3WoZQzYVVAvSGsT+B5PH0AJo+NhqyxJALaVovp+AtW5BYWrbb 2JzpPHI5KVeFTzh4Gz2ygOnVRdU5WHr6spn2Uks6S1hhWU0tVcLyogI33jdicyni F6J1yN3GfUK2iqPNQo/fHdKbJA78yVWyimzIakO3zk7f59MJ3QXRgjlCvV1nyEEo O7qdEuzOoBQHWxFM4/mRTFEO4pg3AeZ0ang== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeljedgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Mar 2023 08:57:52 -0500 (EST) From: Thomas Monjalon To: "Zhang, Qi Z" Cc: "dev@dpdk.org" , David Marchand , "Richardson, Bruce" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" , "McDaniel, Timothy" , Ajit Khaparde , Somnath Kotur , "Daley, John" , Hyong Youb Kim , Dongdong Liu , Yisen Zhuang , "Zhang, Yuying" , Maxime Coquelin , "Xia, Chenbo" , Shijith Thotton , "Matz, Olivier" Subject: Re: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode Date: Thu, 02 Mar 2023 14:57:50 +0100 Message-ID: <2030660.o4kTbAZ4gJ@thomas> In-Reply-To: References: <20230219115529.3260580-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/03/2023 14:52, Zhang, Qi Z: > From: Thomas Monjalon > > If IOVA as PA is disabled and the driver does not support IOVA as VA, the > > build of the driver was disabled. > > Unfortunately some drivers were building some sub-libraries (with specific > > options for vector paths) which were not disabled. > > > > The build parsing of those drivers need to be skipped earlier to avoid > > defining the sub-libraries. > > > > Fixes: a986c2b7973d ("build: add option to configure IOVA mode as PA") > > Cc: stable@dpdk.org > > > > Signed-off-by: Thomas Monjalon [...] > > --- a/drivers/meson.build > > +++ b/drivers/meson.build > > @@ -127,9 +127,9 @@ foreach subpath:subdirs > > # pull in driver directory which should update all the local variables > > subdir(drv_path) > > > > - if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 and not > > pmd_supports_disable_iova_as_pa and not > > always_enable.contains(drv_path) > > + if not get_option('enable_iova_as_pa') and not > > + pmd_supports_disable_iova_as_pa and not > > + always_enable.contains(drv_path) > > build = false > > - reason = 'driver does not support disabling IOVA as PA mode' > > + reason = 'IOVA as VA not supported' > > endif > > If we check enable_iova_as_pa for each unsupported driver , do we still need "pmd_supports_disable_iova_as_pa"? They are a bit redundant. The idea is to use pmd_supports_disable_iova_as_pa (could be renamed) as it is simpler to use. But in the case of drivers having sub-libs (always enabled), we need an extra check of enable_iova_as_pa inside the driver file.