From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 34BF41B7CF for ; Tue, 24 Oct 2017 22:47:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B9EDB20ADC; Tue, 24 Oct 2017 16:47:27 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 24 Oct 2017 16:47:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=fCNKA44HMzqISLqBCBbCoaKasU nyPRQQzKDyCfzPxQg=; b=O0btatBu3IAxBAnv0XymP+NQ5yXJ/i8i1o4i/prg8n AUlMYsF96SjeejK5ndCaNYUmaB3VyrHY1ctQdVl06PTTTNcjQGhG2YFGoLXf+Svs M0i7+hU0VrVhNJZyWNQotq0ACSbL36L4AcziGsy1xEZUMb7M+c67kJGxr3KTu27J E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fCNKA4 4HMzqISLqBCBbCoaKasUnyPRQQzKDyCfzPxQg=; b=DIPvnwDL8o///td8CD/EcF 8T5vvoTk3t+wsRPwHxqbpEEswNOa/sA5z0H8t+y4HvIz3s1PF6HSirtsISDMukNO tTHAWg9GiseJiuRDy0IWneltH9dONphxoQux74gQ3eimpGbw/3xfA7f46NL6BW6K eOSoBARIU5d5tPivik9X2CbbsImwSx5d6dIA9C4rDGI0S6DF73/GfstP7GO/j/3j dJAsK72YEDoGQCqNgYZlrlCKcgo7Kg2bQAoGaa+/MF0vWPb4FPtJbJ5owl1uytSn lH1yYOkVgWU+zIYa5rp2viMGJgNaE5sl/Y6/xG/i4VV5pHcawhHzuMftgMpP7aSw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5FA607F96B; Tue, 24 Oct 2017 16:47:27 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal Cc: dev@dpdk.org, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com, hemant.agrawal@nxp.com, radu.nicolau@intel.com, borisp@mellanox.com, aviadye@mellanox.com, sandeep.malik@nxp.com, jerin.jacob@caviumnetworks.com, john.mcnamara@intel.com, konstantin.ananyev@intel.com, shahafs@mellanox.com, olivier.matz@6wind.com Date: Tue, 24 Oct 2017 22:47:26 +0200 Message-ID: <2031024.JVCIT9oVUT@xps> In-Reply-To: <20171024141545.30837-2-akhil.goyal@nxp.com> References: <20171014221734.15511-1-akhil.goyal@nxp.com> <20171024141545.30837-1-akhil.goyal@nxp.com> <20171024141545.30837-2-akhil.goyal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 01/11] lib/rte_security: add security library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 20:47:28 -0000 Hi, I am waiting the crypto subtree to be ready before getting this series. Some last comments below, 24/10/2017 16:15, Akhil Goyal: > +Security API - EXPERIMENTAL > +M: Akhil Goyal > +M: Declan Doherty > +F: lib/librte_security/ > +F: doc/guides/prog_guide/rte_security.rst > > Networking Drivers > ------------------ An additional blank line is missing. > +# build flags > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) As said by Pablo, please fix the build with LDLIBS. > +/** > + * @file rte_security.h > + * > + * RTE Security Common Definitions > + * > + */ You should add this line: @b EXPERIMENTAL: this API may change without prior notice > --- /dev/null > +++ b/lib/librte_security/rte_security_version.map > @@ -0,0 +1,13 @@ > +DPDK_17.11 { The name of this block should be EXPERIMENTAL > + global: > + > + rte_security_attach_session; > + rte_security_capabilities_get; > + rte_security_capability_get; > + rte_security_session_create; > + rte_security_session_destroy; > + rte_security_session_stats_get; > + rte_security_session_update; > + rte_security_set_pkt_metadata; > + > +}; I think you need this line: local: *;