From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5BE41A04B1;
Wed, 4 Nov 2020 18:55:47 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 2757D2BE2;
Wed, 4 Nov 2020 18:55:45 +0100 (CET)
Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com
[66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 6607823D
for <dev@dpdk.org>; Wed, 4 Nov 2020 18:55:42 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailnew.nyi.internal (Postfix) with ESMTP id CD11A580A9B;
Wed, 4 Nov 2020 12:55:41 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Wed, 04 Nov 2020 12:55:41 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
YZaT4TFWPZHVWlgUs1osDiGAgvjJY/5zYHzJt9FB7LU=; b=UB489JRAq7QqNwzl
C3OqL6bQ4M9HEEU7A7a2NvvUlN1cDLHvua6ACeHvTVZ6pEp5jRS5Hfrb5RuuvtQP
x04rhPKrZHjbI6f8nzSl+9qgc2PpVG5vYDYnSJVK/M3UXAO/oHZUkCIqG/EeVDWd
pAF8WzfKqAQEIW4qSGxrlSBKGSXBHEvHs7Sz9kRN4GF4MDRTXqAEPFpqNdslnjbu
KoxE3Z7ZoltnWwla6T/Zp1ZX333rFNpleQhkBSYOOYE6sTYCULJ7Q1P42SN9cJhx
UWvZY/I50ysZ5CS+4nPcgemx+Wy8y7EN8QM5E7PhsIQq1oC42D04D8n8dq+n3+zl
XKI5Ww==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=YZaT4TFWPZHVWlgUs1osDiGAgvjJY/5zYHzJt9FB7
LU=; b=rvMWc2xN4paOpOPccC4LWKTVT+dt4C+4dfORlZ+wlZFDvHzaC8v+Hmho0
Vht7rz0OdYWE+dqg6jvJ00rcUlUZOc27g8tP4DU5eK7H7nbDT7FUot7eJrhyjVB/
K0w5E+5KOiN84rYsCElgw4Hr/63uxeaVzCzsTNCX7HVIsrWPo+45+xX++qvf0q8T
QF3G3tcLhBDmxGO7CUGv9k+/KWGvV5siGgWaDmH4usrlCWwIKutrnF01tLSHI/9R
kD8yxDhDQAs+f3EcjOmyPnOStZkZ70kYVPccjaxFM839KORgz9G6GQOBdhncGVbI
FI7WlbGx2Bvho0cpBMRcS56Ic3khw==
X-ME-Sender: <xms:HOuiX1Ef3YCxSH75ovmjpmZPzwOGSonZ4afm5DPpPvuw3s6cBIaGBw>
<xme:HOuiX6U36-z-_vRGr0crfOD1i9O5-ybDvTEWGOX4myqRr88ox9p7OlrLidXCXJpfa
5gdJPWq2ZOBkI4cWA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddthedguddtjecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej
ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh
fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr
lhhonhdrnhgvth
X-ME-Proxy: <xmx:HOuiX3JHoY0aWsA-rtY20B3S2z7UDlO07Rpm7eOlG84JLCthJCL50g>
<xmx:HOuiX7FD1zFavNF3dkhEDjm--S5J9Amb9mAmTcgdEe5YtziD0j9Wmg>
<xmx:HOuiX7Wc6MDSwJCK_NcgKH19KxxF-2eT-kJOoWml1Z1j7HoPeOEqKw>
<xmx:HeuiX7SyeH-XQJO_o-u5Ew8JpU3FuWSaiVxRh5AiizmpeNhTLGUL4Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id D410C3064610;
Wed, 4 Nov 2020 12:55:38 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: SteveX Yang <stevex.yang@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, beilei.xing@intel.com,
wenzhuo.lu@intel.com, bernard.iremonger@intel.com, qiming.yang@intel.com,
mdr@ashroe.eu, nhorman@tuxdriver.com, david.marchand@redhat.com,
andrew.rybchenko@oktetlabs.ru
Date: Wed, 04 Nov 2020 18:55:34 +0100
Message-ID: <2034736.YrmxQ9UtPI@thomas>
In-Reply-To: <13d2c6ad-c14b-b471-5920-ec3c552b7a61@intel.com>
References: <20201028030334.30300-1-stevex.yang@intel.com>
<2392354.O08QGPWUWg@thomas> <13d2c6ad-c14b-b471-5920-ec3c552b7a61@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length
for VLAN packets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
04/11/2020 18:07, Ferruh Yigit:
> On 11/4/2020 4:51 PM, Thomas Monjalon wrote:
> > 03/11/2020 14:29, Ferruh Yigit:
> >> On 11/2/2020 11:48 AM, Ferruh Yigit wrote:
> >>> On 11/2/2020 8:52 AM, SteveX Yang wrote:
> >>>> When the max rx packet length is smaller than the sum of mtu size and
> >>>> ether overhead size, it should be enlarged, otherwise the VLAN packets
> >>>> will be dropped.
> >>>>
> >>>> Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines")
> >>>>
> >>>> Signed-off-by: SteveX Yang <stevex.yang@intel.com>
> >>>
> >>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>
> >> Applied to dpdk-next-net/main, thanks.
> >>
> >> only 1/2 applied since discussion is going on for 2/2.
> >
> > I'm not sure this testpmd change is good.
> >
> > Reminder: testpmd is for testing the PMDs.
> > Don't we want to see VLAN packets dropped in the case described above?
> >
>
> The patch set 'max_rx_pkt_len' in a way to make MTU 1500 for all PMDs,
> otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN' value, which makes MTU
> between 1492-1500 depending on PMD.
>
> It is application responsibility to provide correct 'max_rx_pkt_len'.
> I guess the original intention was to set MTU as 1500 but was not correct for
> all PMDs and this patch is fixing it.
>
> The same problem in the ethdev, (assuming 'RTE_ETHER_MAX_LEN' will give MTU
> 1500), the other patch in the set is to fix it later.
OK but the testpmd patch is just hiding the issue, isn't it?