From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0467D423B5; Thu, 12 Jan 2023 10:11:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF9C540156; Thu, 12 Jan 2023 10:11:02 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 98DEF400EF for ; Thu, 12 Jan 2023 10:11:01 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 08862580980; Thu, 12 Jan 2023 04:10:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 12 Jan 2023 04:10:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1673514659; x= 1673521859; bh=+zfyDnKx67x2f0gbRNAYp5SExCpanbPYQpTUW3FHZ3Y=; b=A m90/jCbamOgj7GdrWp75rR+ZS+1h20y82VLkFSZTmCOMH45cLf1L6Cl0F01Ml04Q QGXjml9hvX2jYk1uynzIvD495QHzk3C3r3jOOOdjaKSpf+tIg2wQYLZHAH+r1IG3 +eVGWwVg7FOHlpAM7HjmWgZDkSPImuXXR67mZ/5enielY65RMVufibn1TPbCKOpv +MUO6Y5HW64B97KUvJDHICkq4F99xe+mIfM7VKLai8oCFX9x6tGUo29F2r8SkneZ yRMeh7yh70orLlYFlpBJz36B7vPugYeoyRmNCatPCfU30XWJvpa9ssC96zI9FP88 TPzePNGKryns3dH/GEauA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673514659; x= 1673521859; bh=+zfyDnKx67x2f0gbRNAYp5SExCpanbPYQpTUW3FHZ3Y=; b=G VYbQop3LPUJjJpooaa9cAnq1S6UjaJ/vs9SeToORtBtZs0efkLjdlA689BGNAdx4 g/vsXh9sX3x0JsOJwRvKYJ68ml2tq+yypoPCW9UQjUipt3DBxcOd+lnqQ6D42zjx w6nWs6co+QYa+TU14gEy6aMwERfUna97LCd7usRp6/vgUNTsMQ3AIrs1vZiiPNP+ x8RrJKNyk7MfcT6jhLldc/NrEFl2Qgw7qU866Tn2MM72/dLqLvku/sMV4wIkY/6d l20dLQ6WIba3WuoC1k1LfxPuBO+21C+MMA3DXKRCjL1pOqEhW+/WKyxtmxYOetG2 F1IQdSbu2nj+Tjw7Mj1Iw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleeiucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrg htthgvrhhnpeduieffieejvdevuefhhfeihfeftedtleekjefhheehtdegtedukeefueel tedtueenucffohhmrghinhepthgvshhtrdhtphenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Jan 2023 04:10:49 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , Jerin Jacob , jerinj@marvell.com Cc: dev@dpdk.org, Ankur Dwivedi , orika@nvidia.com, ferruh.yigit@xilinx.com, chas3@att.com, humin29@huawei.com, linville@tuxdriver.com, ciara.loftus@intel.com, qi.z.zhang@intel.com, mw@semihalf.com, mk@semihalf.com, shaibran@amazon.com, evgenys@amazon.com, igorch@amazon.com, chandu@amd.com, irusskikh@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, jerinj@marvell.com, mczekaj@marvell.com, sthotton@marvell.com, srinivasan@marvell.com, hkalra@marvell.com, rahul.lakkireddy@chelsio.com, johndale@cisco.com, hyonkim@cisco.com, liudongdong3@huawei.com, yisen.zhuang@huawei.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, simei.su@intel.com, wenjun1.wu@intel.com, qiming.yang@intel.com, Yuying.Zhang@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, rosen.xu@intel.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com, lironh@marvell.com, zr@semihalf.com, radhac@marvell.com, vburru@marvell.com, sedara@marvell.com, matan@nvidia.com, viacheslavo@nvidia.com, sthemmin@microsoft.com, longli@microsoft.com, spinler@cesnet.cz, chaoyong.he@corigine.com, niklas.soderlund@corigine.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, g.singh@nxp.com, apeksha.gupta@nxp.com, sachin.saxena@nxp.com, aboyer@pensando.io, rmody@marvell.com, shshaikh@marvell.com, dsinghrawat@marvell.com, andrew.rybchenko@oktetlabs.ru, jiawenwu@trustnetic.com, jianwang@trustnetic.com, jbehrens@vmware.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, steven.webster@windriver.com, matt.peters@windriver.com, bruce.richardson@intel.com, mtetsuyah@gmail.com, grive@u256.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, jgrajcia@cisco.com, david.marchand@redhat.com Subject: Re: [PATCH v3 1/4] ethdev: add trace points Date: Thu, 12 Jan 2023 10:10:47 +0100 Message-ID: <2036238.VLH7GnMWUR@thomas> In-Reply-To: References: <20220929102936.5490-1-adwivedi@marvell.com> <7a06cfd9-f9de-2df5-d172-44aef97b7529@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/12/2022 07:49, Jerin Jacob: > On Wed, Dec 14, 2022 at 5:40 PM Ferruh Yigit wrote: > > > > On 12/14/2022 10:40 AM, Jerin Jacob wrote: > > > On Wed, Dec 14, 2022 at 1:37 AM Ferruh Yigit wrote: > > >> 4) Why we need to export trace point variables in the .map files, > > >> like '__rte_eth_trace_allmulticast_disable' one... > > > > > > If you see app/test/test_trace.c example > > > > > > There are two-way to operate on trace point, We need to export symbol > > > iff we need option 1 > > > > > > option1: > > > rte_trace_point_enable(&__app_dpdk_test_tp); > > > > > > option2: > > > rte_trace_point_t *trace = rte_trace_point_lookup("app.dpdk.test.tp"); > > > rte_trace_point_enable(trace); > > > > > > > got it, do we really need direct access to trace point (option 1), I > > would be OK to remove that option to not expose all these trace point > > objects. > > Looks good to me. I would like to see a policy regarding trace symbols. If we decide option 1 is not so useful, then we should not export trace symbols at all and document this policy. Also there are some trace symbols which could be cleaned up.