DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>,
	ktraynor@redhat.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 2/2] eal: restrict ctrl threads to startup cpu affinity
Date: Thu, 07 Mar 2019 19:23:02 +0100	[thread overview]
Message-ID: <2037140.URYxlzVuUZ@xps> (raw)
In-Reply-To: <20190225083359.uzvwejkej3elyqdh@platinum>

25/02/2019 09:33, Olivier Matz:
> On Wed, Feb 20, 2019 at 04:01:33PM +0000, Burakov, Anatoly wrote:
> > On 19-Feb-19 8:41 PM, David Marchand wrote:
> > > Spawning the ctrl threads on anything that is not part of the eal
> > > coremask is not that polite to the rest of the system, especially
> > > when you took good care to pin your processes on cpu resources with
> > > tools like taskset (linux) / cpuset (freebsd).
> > > 
> > > Rather than introduce yet another eal options to control on which cpu
> > > those ctrl threads are created, let's take the startup cpu affinity
> > > as a reference and remove the eal coremask from it.
> > > If no cpu is left, then we default to the master core.
> > > 
> > > The cpuset is computed once at init before the original cpu affinity
> > > is lost.
> > > 
[...]
> > > 
> > > Fixes: d651ee4919cd ("eal: set affinity for control threads")
> > > Cc: stable@dpdk.org
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > 
> > Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>

Replaced cpu by uppercase CPU,
and applied, thanks

  reply	other threads:[~2019-03-07 18:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 16:13 [dpdk-dev] [PATCH] " David Marchand
2019-02-13 20:21 ` David Marchand
2019-02-14  9:39 ` Burakov, Anatoly
2019-02-14  9:53   ` David Marchand
2019-02-14 10:04     ` Burakov, Anatoly
2019-02-14 10:16       ` David Marchand
2019-02-14 11:05 ` David Marchand
2019-02-14 13:30 ` [dpdk-dev] [PATCH v2 1/2] eal: fix potential incorrect pinning for ctrl threads David Marchand
2019-02-14 13:30   ` [dpdk-dev] [PATCH v2 2/2] eal: restrict ctrl threads to startup cpu affinity David Marchand
2019-02-19 11:38     ` Burakov, Anatoly
2019-02-19 11:51       ` David Marchand
2019-02-19 16:03         ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-02-14 16:12   ` [dpdk-dev] [PATCH v2 1/2] eal: fix potential incorrect pinning for ctrl threads Burakov, Anatoly
2019-02-14 17:45     ` David Marchand
2019-02-19 20:41   ` [dpdk-dev] [PATCH v3 " David Marchand
2019-02-19 20:41     ` [dpdk-dev] [PATCH v3 2/2] eal: restrict ctrl threads to startup cpu affinity David Marchand
2019-02-20 16:01       ` Burakov, Anatoly
2019-02-25  8:33         ` Olivier Matz
2019-03-07 18:23           ` Thomas Monjalon [this message]
2019-02-20 16:01     ` [dpdk-dev] [PATCH v3 1/2] eal: fix potential incorrect pinning for ctrl threads Burakov, Anatoly
2019-02-25  8:33       ` Olivier Matz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2037140.URYxlzVuUZ@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ktraynor@redhat.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).