DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Yangchao Zhou <zhouyates@gmail.com>
Cc: stable@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] kni: fix possible rx_q mbuf leaks and speed up alloc_q release
Date: Mon, 14 May 2018 00:02:54 +0200	[thread overview]
Message-ID: <2037639.XKrTCuadTR@xps> (raw)
In-Reply-To: <6be3fba4-46d8-45f6-caa0-7b301433a964@intel.com>

04/05/2018 14:46, Ferruh Yigit:
> On 4/19/2018 4:12 AM, Yangchao Zhou wrote:
> > rx_q fifo can only be released by kernel thread. There may be
> > mbuf leaks in rx_q because kernel threads are randomly stopped.
> > 
> > When the kni is released and netdev is unregisterd, convert the
> > physical address mbufs in rx_q to the virtual address in free_q.
> > By the way, alloc_q can be processed together to speed up the
> > release rate in userspace.
> > 
> > In my test, it is improved from 300-500ms with a mempool that has
> >  131072 mbufs to 10ms(regardless of the specifications).
> > 
> > Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> > Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > v4:
> > * Add improve performance description.
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks

      reply	other threads:[~2018-05-13 22:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11 12:34 [dpdk-dev] [PATCH v2] kni: fix possible rx_q mbuf leak " Yangchao Zhou
2018-04-17  4:01 ` [dpdk-dev] [PATCH v3] kni: fix possible rx_q mbuf leaks " Yangchao Zhou
2018-04-17 19:11   ` Ferruh Yigit
2018-04-19  3:12     ` [dpdk-dev] [PATCH v4] " Yangchao Zhou
2018-05-04 12:46       ` Ferruh Yigit
2018-05-13 22:02         ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2037639.XKrTCuadTR@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    --cc=zhouyates@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).