From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 4A1008DAB; Mon, 14 May 2018 00:02:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D09F424B09; Sun, 13 May 2018 18:02:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 13 May 2018 18:02:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=pACsiZ2DMp4NRjL0LoXkydAYyx JrKqgy4oLmzMNLyqE=; b=Thf9j1ZrmA/mHmXvDhRWNRj92LNqiviWQ+UBP47tgd X6oMqz80SYt5SZZkoEVfbFtiIks49xmjap6v0PTuQvDGvrQUpHLkbT4u3fAhn6UV phfOqNw9c4O6yQpTlwBUqUECD3ByI1fP40TsEMVO0Lg4i6u8GXpTr8PBSEn8FnhB k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=pACsiZ 2DMp4NRjL0LoXkydAYyxJrKqgy4oLmzMNLyqE=; b=L6Z5X73P9CYQ5tNNAOU34L 1VHh0lSpx4LNft9Mwgcjxq4cQ3yV9fJKFPAIu1tvpmsSm9nYrmCBDwkV3WhcGIGz ZN31rzONYEbQoMNq9Yo/jD276dyvRChrg6dfanueKIKmQ3D3nIXHjlNGhKmaKUds as8uw+zSrUMMr7TSXzVkEjty8U7DYu0MAlRTxjErMupvnEnTdCgdJicryNVr0CVD iXiXHygaCFwhPZF5FvUqOmo5LOkTRg8dgYou0pDrfukJiXhDtn6ty78lxg7NN/AA bftrfBmLtFkSerfJHuEjs+y4weNgSi4v0oRykfUP0nR2lB9xr+eNKU05qK4dSc7Q == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2D3B8E4412; Sun, 13 May 2018 18:02:55 -0400 (EDT) From: Thomas Monjalon To: Yangchao Zhou Cc: stable@dpdk.org, Ferruh Yigit , dev@dpdk.org Date: Mon, 14 May 2018 00:02:54 +0200 Message-ID: <2037639.XKrTCuadTR@xps> In-Reply-To: <6be3fba4-46d8-45f6-caa0-7b301433a964@intel.com> References: <9a57896f-a2db-7f4b-f5c4-cf04970f1636@intel.com> <1524107540-11544-1-git-send-email-zhouyates@gmail.com> <6be3fba4-46d8-45f6-caa0-7b301433a964@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] kni: fix possible rx_q mbuf leaks and speed up alloc_q release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 May 2018 22:02:56 -0000 04/05/2018 14:46, Ferruh Yigit: > On 4/19/2018 4:12 AM, Yangchao Zhou wrote: > > rx_q fifo can only be released by kernel thread. There may be > > mbuf leaks in rx_q because kernel threads are randomly stopped. > > > > When the kni is released and netdev is unregisterd, convert the > > physical address mbufs in rx_q to the virtual address in free_q. > > By the way, alloc_q can be processed together to speed up the > > release rate in userspace. > > > > In my test, it is improved from 300-500ms with a mempool that has > > 131072 mbufs to 10ms(regardless of the specifications). > > > > Signed-off-by: Yangchao Zhou > > Suggested-by: Ferruh Yigit > > --- > > v4: > > * Add improve performance description. > > Acked-by: Ferruh Yigit Applied, thanks