From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15736A0C47; Tue, 12 Oct 2021 18:09:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90E934111B; Tue, 12 Oct 2021 18:09:16 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 78E5841103 for ; Tue, 12 Oct 2021 18:09:15 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 20A63580ADF; Tue, 12 Oct 2021 12:09:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 12 Oct 2021 12:09:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= x8k9C+gKHoJHVLfo/rJmtg9PGbAMcEgTkkeFrqGMNAY=; b=eYNKwH9/KDRqPU0r vPg7mGhbUD7eIhvOeh4fWNCODnD6eI8GM0Pp/g65asuChT8WjsWJnhGDS0l9zFFl 4alxaAw5EroRYabtGmBtixLiaIPJaGSwxyS+LrZICTf/XFcPi4A/cbfQOIJC3Hr+ QqM3EVCwEkLTXwEPFw8+UBnZX9XbH3y3zXRlP/QHvpEKYj6k+CfH36VSEEFAwbzF w/a1X/6byiLLrS2ZmkDdjRuwnXZRvWOts9mSUJEGA7Lz1E3DKKJehn/FwPJTiiy4 lqBpih7XCy+QZcXCQJoYJxcFompkcNKXg3VT2s1lDa7NazalUtTGNTYySpkjwqfI VkfLcg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=x8k9C+gKHoJHVLfo/rJmtg9PGbAMcEgTkkeFrqGMN AY=; b=JNbvwOfkhlhDuAmu7O4QedR10zFMD8j27W4dBVS4SozIXlsKLfahj8Irb OQ4JxoNBHi3bFgpst1DX+pmxDULlfwQS/2m3reO8cUnVO4pLKvBWkmssuV004T3Q CYsIZs7tQ/7VmpPmCf/sY8/C2VQGIZl2L0T8OD3qAsTvnZLNSPRflIU+Fwc3cSPE zgSyvXVXhGR4KnlKxZWiz4vW9ZlG1UU/6hNPtR3LwHnw5z9ON9xOJYTSc8bllorc HwC6mBBibQbZVvYjamwTdAWgrn7Y0c+9LpsujFHy4L40stWogAFKKqBB1P/fRDbe WiwZV651ritvgsl0xr0w3QU6fd9dw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddtkedgleegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Oct 2021 12:09:12 -0400 (EDT) From: Thomas Monjalon To: Narcisa Ana Maria Vasile Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, khot@microsoft.com, dmitrym@microsoft.com, roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com, bruce.richardson@intel.com, david.marchand@redhat.com, pallavi.kadam@intel.com Date: Tue, 12 Oct 2021 18:09:10 +0200 Message-ID: <2039707.RtrpYhFy17@thomas> In-Reply-To: <1633765318-28356-2-git-send-email-navasile@linux.microsoft.com> References: <1633732841-17873-1-git-send-email-navasile@linux.microsoft.com> <1633765318-28356-1-git-send-email-navasile@linux.microsoft.com> <1633765318-28356-2-git-send-email-navasile@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v16 1/9] eal: add basic threading functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/10/2021 09:41, Narcisa Ana Maria Vasile: > From: Narcisa Vasile > > Use a portable, type-safe representation for the thread identifier. > Add functions for comparing thread ids and obtaining the thread id > for the current thread. > > Signed-off-by: Narcisa Vasile > --- > lib/eal/common/meson.build | 1 + > lib/eal/{unix => common}/rte_thread.c | 57 ++++++++++++++++----------- There is no explanation about this move. > lib/eal/include/rte_thread.h | 48 +++++++++++++++++----- > lib/eal/unix/meson.build | 1 - > lib/eal/version.map | 3 ++ > lib/eal/windows/rte_thread.c | 17 ++++++++ > 6 files changed, 95 insertions(+), 32 deletions(-) > rename lib/eal/{unix => common}/rte_thread.c (66%) [...] > - err = pthread_key_create(&((*key)->thread_index), destructor); > - if (err) { > + err = pthread_key_create(&(k->thread_index), destructor); > + if (err != 0) { It looks wrong to call pthread functions in a "common" file.