From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B87C3A0C50; Sat, 24 Jul 2021 09:58:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39D1040DDE; Sat, 24 Jul 2021 09:58:25 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 29B3D40DDA for ; Sat, 24 Jul 2021 09:58:24 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id E0F1E320031A; Sat, 24 Jul 2021 03:58:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 24 Jul 2021 03:58:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= VSdqR0CFcYtdTLZk0SgWifrmYn0gf5zJGBXaCU44UBk=; b=z5Pbya3jl7tBDYGo S7BzKrT3Nja69W9jwaYNu6DTj0BklE8zI7BMh4zpeY6dfDu3EMuCXrBsR5YAeN+N 5U3xLDpGquYlyf9lm9fW5aOMp0lnA7xCsEavwp7Sjtfsu7Wy8NpbNMlrhBW1ILrQ efWluwaCf/Cr1vtOsCiRh6cN4xTo3rqaD5Ll6exK9a1xzBHx+TsntxDb1w9jDZCV YPcy0FT471wIOATpEpzjubgHP/9d+w9nvjYlgIla0UOnW+x4nNpuf3aVp/7zsduF 98FsMldCjfq/mw0vEphKM/wUy3JqtaP4DUAgfNQV4McUET55tThxYIVmCMFKGB+I Dou2bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=VSdqR0CFcYtdTLZk0SgWifrmYn0gf5zJGBXaCU44U Bk=; b=ZDbA0dY7jfj4rrTSfkzoERa8LHt+7tEG2UQbG21/Ex9WxEHEvJo09Q+Cj 1xIfSLi3OoaOyxuFozotRNCjDLikqUxo+d0xA3yT8SYr38lJ8VEuRCOn1H2UZVD6 nJLkWmsaTmrGghPfCbnTydt6E5zJBt1tPdlnE88CJu5Mn3m/AzhNSPGe9cggOLN2 KT8zVskubm9001ZvAdBRYNp8JWsggMp4VYsThdKT516Jllu5v4SJiLhQeKozJWqj De3hJ219l6Bsi5ybYWwAW9y4RNaz1ZvwgtnwZooc12Dhv0U3aPdHK8bEIs80J480 eoobP2PjXrdTzVAjC6RzLb6ytEt5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeelgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Jul 2021 03:58:20 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, anatoly.burakov@intel.com, Tyler Retzlaff Date: Sat, 24 Jul 2021 09:58:44 +0200 Message-ID: <2040984.QlECWYl36d@thomas> In-Reply-To: <20210723154546.7958-1-stephen@networkplumber.org> References: <20210713201221.301248-1-stephen@networkplumber.org> <20210723154546.7958-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] eal: fix argument to rte_bsf32_safe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/07/2021 17:45, Stephen Hemminger: > The first argument to rte_bsf32_safe was incorrectly declared as > a 64 bit value. The code only works on 32 bit values and the underlying > function rte_bsf32 only accepts 32 bit values. This was a mistake > introduced when the safe version was added and probably cause > by copy/paste from the 64 bit version. > > The bug passed silently under the radar until some other code was > built with -Wall and -Wextra in C++ and C++ complains about the > missing cast. > > Yes, this is a API signature change, but the original code was wrong. > It is an inline so not an ABI change. > > Fixes: 4e261f551986 ("eal: add 64-bit bsf and 32-bit safe bsf functions") > Cc: anatoly.burakov@intel.com > Signed-off-by: Stephen Hemminger > Acked-by: Tyler Retzlaff +Cc: stable@dpdk.org Applied, thanks. I think these functions lack a reference to the name Bit Scan Forward.