DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] mk: remove invalid phony target
@ 2017-03-17 17:08 Olivier Matz
  2017-03-20 11:34 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Olivier Matz @ 2017-03-17 17:08 UTC (permalink / raw)
  To: dev; +Cc: thomas.monjalon, ferruh.yigit

There was a typo in the .PHONY for the test-build target. If we fix the
typo, the test-build target does not work, because it won't match the
'%' target anymore.

So just remove the .PHONY.

Fixes: 64592d97c1ae ("mk: do not build tests by default")

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 mk/rte.sdkroot.mk | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
index 7598bde..f20563e 100644
--- a/mk/rte.sdkroot.mk
+++ b/mk/rte.sdkroot.mk
@@ -96,7 +96,6 @@ config showconfigs showversion showversionum:
 test test-basic test-fast test-ring test-mempool test-perf coverage:
 	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@
 
-.PHONY: test-buid
 test: test-build
 
 .PHONY: install
-- 
2.8.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] mk: remove invalid phony target
  2017-03-17 17:08 [dpdk-dev] [PATCH] mk: remove invalid phony target Olivier Matz
@ 2017-03-20 11:34 ` Ferruh Yigit
  2017-03-27  8:43   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-03-20 11:34 UTC (permalink / raw)
  To: Olivier Matz, dev; +Cc: thomas.monjalon

On 3/17/2017 5:08 PM, Olivier Matz wrote:
> There was a typo in the .PHONY for the test-build target. If we fix the
> typo, the test-build target does not work, because it won't match the
> '%' target anymore.
> 
> So just remove the .PHONY.
> 
> Fixes: 64592d97c1ae ("mk: do not build tests by default")
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] mk: remove invalid phony target
  2017-03-20 11:34 ` Ferruh Yigit
@ 2017-03-27  8:43   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-03-27  8:43 UTC (permalink / raw)
  To: Olivier Matz; +Cc: Ferruh Yigit, dev

2017-03-20 11:34, Ferruh Yigit:
> On 3/17/2017 5:08 PM, Olivier Matz wrote:
> > There was a typo in the .PHONY for the test-build target. If we fix the
> > typo, the test-build target does not work, because it won't match the
> > '%' target anymore.
> > 
> > So just remove the .PHONY.
> > 
> > Fixes: 64592d97c1ae ("mk: do not build tests by default")
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-03-27  8:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-17 17:08 [dpdk-dev] [PATCH] mk: remove invalid phony target Olivier Matz
2017-03-20 11:34 ` Ferruh Yigit
2017-03-27  8:43   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).