From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, helin.zhang@intel.com, sergio.gonzalez.monroy@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix unsafe tailq element removal
Date: Fri, 22 Jul 2016 16:56:26 +0200 [thread overview]
Message-ID: <20431323.66BXPug8Lb@xps13> (raw)
In-Reply-To: <1469196122-168989-3-git-send-email-pablo.de.lara.guarch@intel.com>
2016-07-22 15:02, Pablo de Lara:
> i40e driver was removing elements when iterating tailq lists
> with TAILQ_FOREACH macro, which is not safe.
> Instead, TAILQ_FOREACH_SAFE macro is used when removing/freeing
> these elements.
Pablo,
Maybe we should add a note to explain that the bug of freeing
while iterating is seen since the memory is zeroed on free:
ea0bddbd14e6 ("mem: zero out memory on free")
next prev parent reply other threads:[~2016-07-22 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 13:08 [dpdk-dev] [PATCH 0/2] Safe tailq element removal in i40e driver Pablo de Lara
2016-07-22 13:08 ` [dpdk-dev] [PATCH 1/2] eal: add tailq safe iterator macro Pablo de Lara
2016-07-22 13:08 ` [dpdk-dev] [PATCH 2/2] net/i40e: avoid unsafe tailq element removal Pablo de Lara
2016-07-22 14:02 ` [dpdk-dev] [PATCH v2 0/2] Safe tailq element removal in i40e driver Pablo de Lara
2016-07-22 14:02 ` [dpdk-dev] [PATCH v2 1/2] eal: add tailq safe iterator macro Pablo de Lara
2016-07-22 14:02 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: fix unsafe tailq element removal Pablo de Lara
2016-07-22 14:56 ` Thomas Monjalon [this message]
2016-07-22 16:23 ` [dpdk-dev] [PATCH v2 0/2] Safe tailq element removal in i40e driver Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20431323.66BXPug8Lb@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).