From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 71AC6559A for ; Fri, 14 Jul 2017 19:14:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 17312209F2; Fri, 14 Jul 2017 13:14:40 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 14 Jul 2017 13:14:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=/jK9EbGUuv8+XSC WrdKLL47w1+j6l72Mk5OHhdk3dfE=; b=fR1kFH5jQG0ItDd9sKm7rivl+xXEh+j jzDywrLoQC9IOfbbHiIcfXrtjYXvEZ42EcF0zuNTglqSUGWj6owKN/jX2DI/H96Q 6Egbc5IB7El8lqr9s6QYFZUo6sLeGipKpDp8Vrr3hgXpGDRhDxiOWFlCHBLet62f RTkwvl1X9hIA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=/jK9EbGUuv8+XSCWrdKLL47w1+j6l72Mk5OHhdk3dfE=; b=qkpqxckU UNvPBbG8+wKdPRyD+6deSrSguMFNg9HUaHVfGkQQpk83Ahtyf0onfUHPHOZD7ge5 enfvExlWU2X0u6igAzhpRYxTVG31EhSL1eHJHaW6EzT3c4qR6wgRUDV8G+3gv2WA E3gOJRiVy7DLiyQJaMktrbHL4ZfWSlhDYDNGe0NmE6FRIJXsk1q6ee13qyng/sVx XzqkZA2G7yhTKv/ktFmuxnOnuRcMukT+7AXnh7TS1CddgHtwaDTF5MFdtuey17yQ ssNwTMWCeYqwtZ6uGyQ9HJ4bRO391JwuC6+rvsR05NGYWbPkkiLMxG19EFIJnyek TJy5GJAWC60GrA== X-ME-Sender: X-Sasl-enc: IcClHaB8JVIJ8GQJOg9G2v6USzmSKXlSVJ5yUq33HKUK 1500052479 Received: from xps.localnet (apoitiers-656-1-613-51.w109-214.abo.wanadoo.fr [109.214.42.51]) by mail.messagingengine.com (Postfix) with ESMTPA id 8E9087E1FC; Fri, 14 Jul 2017 13:14:39 -0400 (EDT) From: Thomas Monjalon To: "Wiles, Keith" Cc: dev@dpdk.org Date: Fri, 14 Jul 2017 19:14:37 +0200 Message-ID: <2044129.mseWKSvA0o@xps> In-Reply-To: <4333988E-6D77-4DB1-B37A-1FD508EEB34F@intel.com> References: <20170706213703.69808-1-keith.wiles@intel.com> <4333988E-6D77-4DB1-B37A-1FD508EEB34F@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH RFC] usertools: add dpdk run script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2017 17:14:40 -0000 14/07/2017 18:19, Wiles, Keith: > > On Jul 6, 2017, at 4:37 PM, Keith Wiles wrote: > > > > I use a script like this one with pktgen and wanted to see if DPDK > > would be interested in this application. > > > > The following script adds support for executing applications using > > a configuration file. The configuration file is formatted as a > > python data file to be loaded by the run.py script. > > > > Inside the configuration 'default.cfg' is the command line arguments > > needed to execute the application. Any number of configuration files > > are allows for a single application for different execution. Normally > > the configuration file can be in the application or example directory > > or placed in a RTE_SDK/cfg directory. > > > > The configuration file contains information about setup of the system > > and how to run the application. The run.py script can setup the system > > and/or execute the application with a simple command. > > > > ./run.py -s default # for setup > > ./run.py default # to execute the application. > > > > I am not a great Python coder and any suggestions/patches would be great. > > No comments on this RFC, should I submit a normal patch? I have not reviewed the script. I have just a comment about the scope of the project, as usual ;) I am a bit worried about adding some application facilities which may disturb library development focus of the project. An open discussion would be useful on this topic, so opinions (or +1/-1) are welcome!