From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 43B6C1B4A6 for ; Tue, 16 Apr 2019 12:10:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 85F8E901E; Tue, 16 Apr 2019 06:10:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 16 Apr 2019 06:10:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=0cBw3M/euJGdDBMGBiCPg4Q1YWeu7e3u71kml5Rk+WQ=; b=kng+t2cUL5cF bx1AWJAXB3Qks6WExq5sKKuqNm2vbfHbt0iEIoLT8wsu2xCEKNQJvvx1tA30LiCa 9qfA1V04Tbn5CUMyLfMYZdA/o/eWHXlZNj8pV5y0tQCwgHUxvILDQ/12Pffo8qwp HswXXIxilHUDIwJdTCA7jUCUCV+u8io= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=0cBw3M/euJGdDBMGBiCPg4Q1YWeu7e3u71kml5Rk+ WQ=; b=48eReozmYzQ5vZkJOxImeAFX9FbK45qiTOlak4gJe2AQur+quZJ7K6YmN nQS1ZtmWOerLedVqgPBF2RqLMMS0BkXt378ovxkOckZvjN/bxt+nDPAk7JNfSi6E AjXMs8XmfkTR4P0bs3tOqOAlci60qX6QvIYOVzmv3j9stqA6pXk8v6mijtDoey/w hLz1U0o+jgXVi3Y/UDtPlwHZnMRTaKIKObJF/mNba495zZD/hV0Hq8fGXZZzUNml U3q9zOdm86R0jJzZrQKSxl+DPpchLSwMLoacfMI2ddMhVTJRpaH6ZHDBGD70A2f4 Ao/18rwKzB2OYoxXgxCFkT01igK3A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfedugddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2A5B6103D1; Tue, 16 Apr 2019 06:10:06 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Andrew Rybchenko Cc: dev@dpdk.org, Chas Williams , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Matan Azrad , Shahaf Shuler , Rasesh Mody , Shahed Shaikh , Tomasz Duszynski , Liron Himi , Alan Winkowski , Jasvinder Singh , Cristian Dumitrescu Date: Tue, 16 Apr 2019 12:10:03 +0200 Message-ID: <2045151.l0jaYNEMZa@xps> In-Reply-To: <2c51b997-0a9d-95ba-5eeb-2d0067653e14@intel.com> References: <8025349.HGM0LRMdJy@xps> <2c51b997-0a9d-95ba-5eeb-2d0067653e14@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] ethdev flow director/filtering/steering API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 10:10:11 -0000 16/04/2019 11:51, Ferruh Yigit: > On 4/16/2019 10:33 AM, Andrew Rybchenko wrote: > > On 4/12/19 8:57 PM, Ferruh Yigit wrote: > >> On 4/11/2019 9:43 AM, Andrew Rybchenko wrote: > >>> On 4/11/19 10:49 AM, Thomas Monjalon wrote: > >>>> About the features called flow director, filtering or flow steering, > >>>> we have some overlap in our API that we should clean. > >>>> It is especially important when considering to freeze the API for stability. > >>>> > >>>> Please read this deprecation notice from December 2016: > >>>> > >>>> * ethdev: the legacy filter API, including > >>>> ``rte_eth_dev_filter_supported()``, ``rte_eth_dev_filter_ctrl()`` as well > >>>> as filter types MACVLAN, ETHERTYPE, FLEXIBLE, SYN, NTUPLE, TUNNEL, FDIR, > >>>> HASH and L2_TUNNEL, is superseded by the generic flow API (rte_flow) in > >>>> PMDs that implement the latter. > >>>> Target release for removal of the legacy API will be defined once most > >>>> PMDs have switched to rte_flow. > >>>> > >>>> We must mark the eth_dev_filter API as deprecated and decide about > >>>> a date to remove it. > >>>> > >>>> Which PMD is implementing this API and not rte_flow? > >>> In accordance with feature matrix is it i40e_vec, ixgbe_vec and qede, but > >>> I think it is just a mistake in documentation. > >>> > >>> Flow API support tick is missing for many PMDs which actually implement > >>> (as far as I can see): bonding, dppa2, e100, mlx4, qede, mvpp2, softnic. > >>> I've added maintainers to CC. > > > Flow API is about filtering and actions. > > Flow director is mainly filtering approach and I would agree to classify > > it as > > implementation detail. I'd consider to move it under flow API umbrella > > finally, but I don't know enough details on it. > > I was trying to say "flow api" is not target, target is "filtering" support, > "flow api" it method to have it, perhaps can merge "flow API" & "Flow director" > under "flow filtering" ... They are 2 different API for the same purpose. The former is announced to be deprecated for more than 2 years. I'll send a patch to mark it clearly as deprecated. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2AA0AA00E6 for ; Tue, 16 Apr 2019 12:10:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44FDF1B4A7; Tue, 16 Apr 2019 12:10:12 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 43B6C1B4A6 for ; Tue, 16 Apr 2019 12:10:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 85F8E901E; Tue, 16 Apr 2019 06:10:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 16 Apr 2019 06:10:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=0cBw3M/euJGdDBMGBiCPg4Q1YWeu7e3u71kml5Rk+WQ=; b=kng+t2cUL5cF bx1AWJAXB3Qks6WExq5sKKuqNm2vbfHbt0iEIoLT8wsu2xCEKNQJvvx1tA30LiCa 9qfA1V04Tbn5CUMyLfMYZdA/o/eWHXlZNj8pV5y0tQCwgHUxvILDQ/12Pffo8qwp HswXXIxilHUDIwJdTCA7jUCUCV+u8io= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=0cBw3M/euJGdDBMGBiCPg4Q1YWeu7e3u71kml5Rk+ WQ=; b=48eReozmYzQ5vZkJOxImeAFX9FbK45qiTOlak4gJe2AQur+quZJ7K6YmN nQS1ZtmWOerLedVqgPBF2RqLMMS0BkXt378ovxkOckZvjN/bxt+nDPAk7JNfSi6E AjXMs8XmfkTR4P0bs3tOqOAlci60qX6QvIYOVzmv3j9stqA6pXk8v6mijtDoey/w hLz1U0o+jgXVi3Y/UDtPlwHZnMRTaKIKObJF/mNba495zZD/hV0Hq8fGXZZzUNml U3q9zOdm86R0jJzZrQKSxl+DPpchLSwMLoacfMI2ddMhVTJRpaH6ZHDBGD70A2f4 Ao/18rwKzB2OYoxXgxCFkT01igK3A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfedugddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2A5B6103D1; Tue, 16 Apr 2019 06:10:06 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Andrew Rybchenko Cc: dev@dpdk.org, Chas Williams , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Matan Azrad , Shahaf Shuler , Rasesh Mody , Shahed Shaikh , Tomasz Duszynski , Liron Himi , Alan Winkowski , Jasvinder Singh , Cristian Dumitrescu Date: Tue, 16 Apr 2019 12:10:03 +0200 Message-ID: <2045151.l0jaYNEMZa@xps> In-Reply-To: <2c51b997-0a9d-95ba-5eeb-2d0067653e14@intel.com> References: <8025349.HGM0LRMdJy@xps> <2c51b997-0a9d-95ba-5eeb-2d0067653e14@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] ethdev flow director/filtering/steering API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416101003._SJ78Yr5RStu35RbkVO4_gP3U_bFh5nhTv3K82ir_fI@z> 16/04/2019 11:51, Ferruh Yigit: > On 4/16/2019 10:33 AM, Andrew Rybchenko wrote: > > On 4/12/19 8:57 PM, Ferruh Yigit wrote: > >> On 4/11/2019 9:43 AM, Andrew Rybchenko wrote: > >>> On 4/11/19 10:49 AM, Thomas Monjalon wrote: > >>>> About the features called flow director, filtering or flow steering, > >>>> we have some overlap in our API that we should clean. > >>>> It is especially important when considering to freeze the API for stability. > >>>> > >>>> Please read this deprecation notice from December 2016: > >>>> > >>>> * ethdev: the legacy filter API, including > >>>> ``rte_eth_dev_filter_supported()``, ``rte_eth_dev_filter_ctrl()`` as well > >>>> as filter types MACVLAN, ETHERTYPE, FLEXIBLE, SYN, NTUPLE, TUNNEL, FDIR, > >>>> HASH and L2_TUNNEL, is superseded by the generic flow API (rte_flow) in > >>>> PMDs that implement the latter. > >>>> Target release for removal of the legacy API will be defined once most > >>>> PMDs have switched to rte_flow. > >>>> > >>>> We must mark the eth_dev_filter API as deprecated and decide about > >>>> a date to remove it. > >>>> > >>>> Which PMD is implementing this API and not rte_flow? > >>> In accordance with feature matrix is it i40e_vec, ixgbe_vec and qede, but > >>> I think it is just a mistake in documentation. > >>> > >>> Flow API support tick is missing for many PMDs which actually implement > >>> (as far as I can see): bonding, dppa2, e100, mlx4, qede, mvpp2, softnic. > >>> I've added maintainers to CC. > > > Flow API is about filtering and actions. > > Flow director is mainly filtering approach and I would agree to classify > > it as > > implementation detail. I'd consider to move it under flow API umbrella > > finally, but I don't know enough details on it. > > I was trying to say "flow api" is not target, target is "filtering" support, > "flow api" it method to have it, perhaps can merge "flow API" & "Flow director" > under "flow filtering" ... They are 2 different API for the same purpose. The former is announced to be deprecated for more than 2 years. I'll send a patch to mark it clearly as deprecated.