Re: [dpdk-dev] [PATCHv4 1/5] buildtools: Add tool to check EXPERIMENTAL api exports

[Thomas Monjalon <thomas@monjalon.net>]

Hi Neil,

Sorry for the very late review.
I thought review had been done by others but it seems not.
Please find my comments below.

13/12/2017 16:17, Neil Horman:
>  create mode 100755 buildtools/experimentalsyms.sh

When adding a new file, you must reference it in MAINTAINERS.
Please add it in the section "ABI versioning".

> --- /dev/null
> +++ b/buildtools/experimentalsyms.sh

I think the file name should include the word "check".
What about check-experimental-syms.sh ?

> @@ -0,0 +1,35 @@
> +#!/bin/sh

You must insert a SPDX license and copyright here.

> +if [ -d $MAPFILE ]
> +then
> +	exit 0
> +fi
> +
> +if [ -d $OBJFILE ]
> +then
> +	exit 0
> +fi

Why checking for not being a directory?
I guess you could check being a readable file (-r)?
Should it return an error?

> +for i in `awk 'BEGIN {found=0}
> +		/.*EXPERIMENTAL.*/ {found=1}
> +		/.*}.*;/ {found=0}
> +		/.*;/ {if (found == 1) print $1}' $MAPFILE`
> +do
> +	SYM=`echo $i | sed -e"s/;//"`
> +	objdump -t $OBJFILE | grep -q "\.text.*$SYM"
> +	IN_TEXT=$?
> +	objdump -t $OBJFILE | grep -q "\.text\.experimental.*$SYM"
> +	IN_EXP=$?
> +	if [ $IN_TEXT -eq 0 -a $IN_EXP -ne 0 ]
> +	then
> +		echo "$SYM is not flagged as experimental"
> +		echo "but is listed in version map"
> +		echo "Please add __experimental to the definition of $SYM"
> +		exit 1
> +	fi
> +done
> +exit 0

exit 0 is useless at the end of a script.