From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 3FCB52629 for ; Sun, 21 Jan 2018 19:32:11 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7A71420B36; Sun, 21 Jan 2018 13:32:10 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 21 Jan 2018 13:32:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=rce3Cd/zt2T3rJKNJmUS1CGdF5 ce2TGoZaoZZJr1IiU=; b=ZkcO4GDKNg8dS0Nj02BdADt4FiGkxZk8kkWFeMGkv6 Sm5preUQCnxQvvrz0a4Zpqsxw25yqLgk0GNfJF5fjH5hHgdmBUyIqVz70Sv34M2H 0WphWnZLPTuy8oNcDqr40NTVH2HP1iisQ4LoH3XfPkYTaMvCxQ4braItu2BALQj+ U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=rce3Cd /zt2T3rJKNJmUS1CGdF5ce2TGoZaoZZJr1IiU=; b=kpbBooYTYw7w1xgtk5mPFV xSU40DGSR87bF4qp7f4RF+qcorRfHZlNdHdpAQY1gArz0UlRqITM58JiarG/hOaP Igszetm2kb0enPB3SfB+vUASMW/AIxg2U1eFZS9JM+Txg83JK4Ux+v4+19yNxM+c f6fLmbWTdDgY43AHNFgZmhJbpG5FkVdhxkW5L1eFafHC0eYEPMgzPZ98c1SqOIVT SOsXZtE0YCsxsmNOPfMvAJvp9apRT26yOZwHOVNaaqCfE3nmg7IyHLiyMfJb2R+5 0QANC+3aHbRJt0AuaMb0bmgteso9fPuXX4X2Gv59BkNpEE2vQvKW9LLJs4g5/2+g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2AF0D7E3DE; Sun, 21 Jan 2018 13:32:10 -0500 (EST) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, john.mcnamara@intel.com, bruce.richardson@intel.com Date: Sun, 21 Jan 2018 19:31:31 +0100 Message-ID: <2045197.kyHXX1r0IS@xps> In-Reply-To: <20171213151728.16747-2-nhorman@tuxdriver.com> References: <20171201185628.16261-1-nhorman@tuxdriver.com> <20171213151728.16747-1-nhorman@tuxdriver.com> <20171213151728.16747-2-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv4 1/5] buildtools: Add tool to check EXPERIMENTAL api exports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jan 2018 18:32:11 -0000 Hi Neil, Sorry for the very late review. I thought review had been done by others but it seems not. Please find my comments below. 13/12/2017 16:17, Neil Horman: > create mode 100755 buildtools/experimentalsyms.sh When adding a new file, you must reference it in MAINTAINERS. Please add it in the section "ABI versioning". > --- /dev/null > +++ b/buildtools/experimentalsyms.sh I think the file name should include the word "check". What about check-experimental-syms.sh ? > @@ -0,0 +1,35 @@ > +#!/bin/sh You must insert a SPDX license and copyright here. > +if [ -d $MAPFILE ] > +then > + exit 0 > +fi > + > +if [ -d $OBJFILE ] > +then > + exit 0 > +fi Why checking for not being a directory? I guess you could check being a readable file (-r)? Should it return an error? > +for i in `awk 'BEGIN {found=0} > + /.*EXPERIMENTAL.*/ {found=1} > + /.*}.*;/ {found=0} > + /.*;/ {if (found == 1) print $1}' $MAPFILE` > +do > + SYM=`echo $i | sed -e"s/;//"` > + objdump -t $OBJFILE | grep -q "\.text.*$SYM" > + IN_TEXT=$? > + objdump -t $OBJFILE | grep -q "\.text\.experimental.*$SYM" > + IN_EXP=$? > + if [ $IN_TEXT -eq 0 -a $IN_EXP -ne 0 ] > + then > + echo "$SYM is not flagged as experimental" > + echo "but is listed in version map" > + echo "Please add __experimental to the definition of $SYM" > + exit 1 > + fi > +done > +exit 0 exit 0 is useless at the end of a script.