From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A66FA04B5; Thu, 29 Oct 2020 17:11:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 36851CAD4; Thu, 29 Oct 2020 17:11:45 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 58181C9C2 for ; Thu, 29 Oct 2020 17:11:43 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id EE8D13CD; Thu, 29 Oct 2020 12:11:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 29 Oct 2020 12:11:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= AdLroXqI0xebRjtXC9rviOSP7vl2CkxgFSLtbmWZ8jM=; b=jawNB1847zJiNPwt oPCkPha7Prr/5m7EB8cWTxFN9ONN7Mo0TFvJA5rf6mwsP9yyVtSev+8wSns2fDYY 8AUfqCU+lNGoK4q6s4eEmS/19tTgySVp9znXbIaRWU7XdY+TM+XWK3w9RmDB1kSq FGehzrr3gK2CVYjnzL+z7UaXysgHLmgOWwJyhkKfq4ULY5VDc4iTQ5TaSbqFXf6G nHWUb0FB5FBAKRTWjhZok9RFpShsmzjj2yckb4I+zMjhFWlzr49HpSoqQcI/Vzgg MNqrhSTnkFtW6sFhjcRjhBw46SxA1D3+7Up7cJkqxDpTu6p9jycwa12OKwphfjqL qqoM7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=AdLroXqI0xebRjtXC9rviOSP7vl2CkxgFSLtbmWZ8 jM=; b=eH/t85Iqn9NmId3TrtY4XJOuam3Sp2UufDX7lvBysXaTLITWEyQpu2aUU +HGUJqSRercThEnyKEDRgW2SWsSuystEeh892bzzTDHT8DFgKUDrSBLD/JicKHNY 4qoFrpVvbyh7dihgcsNd1aO6hs7noWMbcI15FEqVmKZWR9SAmcN3lUm1gVEoJ4qF MkLPq++SC3zc681OCnMHK7rBl9uyPeVf087a6rl9dOfcGB6s7mbes1vXzuGTnL2O Ehsyiec1B+0pDqUj95ZdI/D2DnxG0MqbIcBLyKF9yLk3MmcumekGPom6O0SLeO2P oTaZevadko8tk0TOC4TuHjDADkWbw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleefgdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6B8613280064; Thu, 29 Oct 2020 12:11:38 -0400 (EDT) From: Thomas Monjalon To: Ori Kam Cc: Andrew Rybchenko , "dev@dpdk.org" , Andrey Vesnovaty , Ferruh Yigit , Ray Kinsella , Neil Horman , Andrew Rybchenko Date: Thu, 29 Oct 2020 17:11:37 +0100 Message-ID: <2047036.ch1fFInd6B@thomas> In-Reply-To: References: <1603961577-13264-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/10/2020 15:39, Ori Kam: > Hi Andrew, > [...] > > A new generic shared actions API may be used to create shared > > counter. There is no point to keep duplicate COUNT action specific > > capability to create shared counters. > > > > Signed-off-by: Andrew Rybchenko > > --- > > In fact, it looks like the next logical step is to remove > > struct rte_flow_action_count completely since counter ID makes > > sense for shared counters only. I think it will just make it > > easiser to use COUNT action. Comments are welcome. [...] > > +* ethdev: Attribute ``shared`` of the ``struct rte_flow_action_count`` > > + is deprecated and will be removed in DPDK 21.11. Shared counters should > > + be managed using shared actions API (``rte_flow_shared_action_create`` > > etc). > > + [...] > > + * @deprecated Shared attribute is deprecated, use generic > > + * RTE_FLOW_ACTION_TYPE_SHARED action. > > + * > > * The shared flag indicates whether the counter is unique to the flow rule the > > * action is specified with, or whether it is a shared counter. > > * > > @@ -2299,7 +2302,8 @@ struct rte_flow_query_age { > > * to all ports within that switch domain. > > */ > > struct rte_flow_action_count { > > - uint32_t shared:1; /**< Share counter ID with other flow rules. */ > > + /** @deprecated Share counter ID with other flow rules. */ > > + uint32_t shared:1; > > uint32_t reserved:31; /**< Reserved, must be zero. */ > > uint32_t id; /**< Counter ID. */ > > }; > > -- > > 2.17.1 > > As much as I agree with your patch, I don't think we should push it since > not all PMD made the move to support count action, so the application still needs > to use this API. > > I think this patch should be done but in next LTS release. The patch is not removing the field, it is just warning it will be removed in next year.