From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2538A0C5A; Mon, 29 Nov 2021 15:02:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB7B74068A; Mon, 29 Nov 2021 15:02:42 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 1FCBE40689 for ; Mon, 29 Nov 2021 15:02:41 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id A478E5C006E; Mon, 29 Nov 2021 09:02:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 29 Nov 2021 09:02:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= r6YND4lCTHDxker/MHGo0ksJJegz1gjpkbZ/12O0164=; b=HK82fPm2Vkpf/42f rWIjQ+2aAdizwVAmeqJmz66f3yMc/bY7FresjBQVKMIPq0Fag5Qirwp04r6w5uTX Zt5Z0F+SwrV0YXvouPXH/a2lbxqUReqjVXxNW1kDlqbPrEjgbdORlMo4UC0FS88O CSDYtMigH2BqP230ZGIj0cXfgNQnvvw/+LKTu/N4ERA2V3j7K1K/A24seNY2TE59 NX4JEM48PA5WtHd2pe5ugUBCL4njUrrGJ2ZIyz+r1VALR36j7WM106nMmpcbmVxf HlTAt9PEOMuw72NOYOdlAVTQsMb4yfIbM4hoBYG1n4PiZ94V9UUmkWJ+r0s1Axrb yK+UPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=r6YND4lCTHDxker/MHGo0ksJJegz1gjpkbZ/12O01 64=; b=d3pAZ7s28vDmbQIH8faQ4fPT6XXkiRQC0M8fpLak9QetpSiT5sbkez/+M +z05qXAC5qUBLm8VFUtEgobJ5EJeahx3vlVi5KP2ULZFj3sHHYJlmjloCuRcr/mE Yez/MCvEX76J2ab7SksWFg7j387DeGVt3OSkdjtfXacAiRWa49MEcBvw77DNkQnM DGsofgA24f+FKNpPIiZXmqcgylsWtFIGwRQqx7Xf8uRAEIdV7cOnmN4JunmVmXJr q1TBVbbOjNbqp8JKORODDODhB18wbUKxgEnIT27IReLfRPTt1UbGX011DuJAkTOO bSFjHJg2EVjzSsxn9+hPvsofZkBEg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrheelgdehlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Nov 2021 09:02:37 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , Bruce Richardson , Josh Soref Cc: Josh Soref , dev@dpdk.org, David Marchand Subject: Re: [PATCH] Spelling Date: Mon, 29 Nov 2021 15:02:36 +0100 Message-ID: <2048067.usQuhbGJ8B@thomas> In-Reply-To: References: <20211126195851.50167-1-jsoref@users.noreply.github.com> <737b8856-a247-3709-ad4c-a074d4547c86@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 29/11/2021 14:59, Bruce Richardson: > On Mon, Nov 29, 2021 at 12:49:56PM +0000, Ferruh Yigit wrote: > > On 11/26/2021 7:58 PM, Josh Soref wrote: > > > diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c > > > index ff7813f9..603e7c91 100644 > > > --- a/app/test-eventdev/test_order_common.c > > > +++ b/app/test-eventdev/test_order_common.c > > > @@ -253,7 +253,7 @@ void > > > order_opt_dump(struct evt_options *opt) > > > { > > > evt_dump_producer_lcores(opt); > > > - evt_dump("nb_wrker_lcores", "%d", evt_nr_active_lcores(opt->wlcores)); > > > + evt_dump("nb_worker_lcores", "%d", evt_nr_active_lcores(opt->wlcores)); > > > > Hi Josh, Thanks for the patch. > > > > The typo fixes for comments and logs are more straightforward, but I have > > mixed feeling about the variable / macro typo fixes, let's see what others > > think. > > > > And I think we should get this patch either one of the first patch or last > > patch to prevent conflict with other patches. > > +1 to being a first patch to start things off clean. > > For the macros, since there is quick a bit of content in the patch, could > we have the patch split into a separate patch for macro changes to review > separately, allowing the simple doc/printf spelling changes to go in > immediately? +1 to start with a patch on doc, comments and log messages