DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] examples/fips_validation: fix incorrect structure used for AES-GCM
@ 2019-11-27  5:00 Anoob Joseph
  2019-11-28 15:12 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Anoob Joseph @ 2019-11-27  5:00 UTC (permalink / raw)
  To: Marko Kovacevic, Akhil Goyal, Pablo de Lara
  Cc: Sucharitha Sarananaga, Jerin Jacob, Narayana Prasad, dev, Anoob Joseph

From: Sucharitha Sarananaga <ssarananaga@marvell.com>

Test vectors for AES-GCM need to be populated by using aead member
and not cipher_auth. Using incorrect member would result in failures
when AES-GCM with non-zero AAD is tried.

Bugzilla ID: 360
Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
---
 examples/fips_validation/fips_validation_gcm.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c
index 0509b10..ea48ddf 100644
--- a/examples/fips_validation/fips_validation_gcm.c
+++ b/examples/fips_validation/fips_validation_gcm.c
@@ -34,29 +34,29 @@
 #define NEG_TEST_STR	"FAIL"
 
 struct fips_test_callback gcm_dec_vectors[] = {
-		{KEY_STR, parse_uint8_known_len_hex_str, &vec.cipher_auth.key},
+		{KEY_STR, parse_uint8_known_len_hex_str, &vec.aead.key},
 		{IV_STR, parse_uint8_known_len_hex_str, &vec.iv},
 		{CT_STR, parse_uint8_known_len_hex_str, &vec.ct},
-		{AAD_STR, parse_uint8_known_len_hex_str, &vec.cipher_auth.aad},
+		{AAD_STR, parse_uint8_known_len_hex_str, &vec.aead.aad},
 		{TAG_STR, parse_uint8_known_len_hex_str,
-				&vec.cipher_auth.digest},
+				&vec.aead.digest},
 		{NULL, NULL, NULL} /**< end pointer */
 };
 struct fips_test_callback gcm_interim_vectors[] = {
-		{KEYLEN_STR, parser_read_uint32_bit_val, &vec.cipher_auth.key},
+		{KEYLEN_STR, parser_read_uint32_bit_val, &vec.aead.key},
 		{IVLEN_STR, parser_read_uint32_bit_val, &vec.iv},
 		{PTLEN_STR, parser_read_uint32_bit_val, &vec.pt},
-		{AADLEN_STR, parser_read_uint32_bit_val, &vec.cipher_auth.aad},
+		{AADLEN_STR, parser_read_uint32_bit_val, &vec.aead.aad},
 		{TAGLEN_STR, parser_read_uint32_bit_val,
-				&vec.cipher_auth.digest},
+				&vec.aead.digest},
 		{NULL, NULL, NULL} /**< end pointer */
 };
 
 struct fips_test_callback gcm_enc_vectors[] = {
-		{KEY_STR, parse_uint8_known_len_hex_str, &vec.cipher_auth.key},
+		{KEY_STR, parse_uint8_known_len_hex_str, &vec.aead.key},
 		{IV_STR, parse_uint8_known_len_hex_str, &vec.iv},
 		{PT_STR, parse_uint8_known_len_hex_str, &vec.pt},
-		{AAD_STR, parse_uint8_known_len_hex_str, &vec.cipher_auth.aad},
+		{AAD_STR, parse_uint8_known_len_hex_str, &vec.aead.aad},
 		{NULL, NULL, NULL} /**< end pointer */
 };
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/fips_validation: fix incorrect structure used for AES-GCM
  2019-11-27  5:00 [dpdk-dev] [PATCH] examples/fips_validation: fix incorrect structure used for AES-GCM Anoob Joseph
@ 2019-11-28 15:12 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2019-11-28 15:12 UTC (permalink / raw)
  To: Anoob Joseph, Sucharitha Sarananaga
  Cc: dev, Marko Kovacevic, Akhil Goyal, Pablo de Lara, Jerin Jacob,
	Narayana Prasad

27/11/2019 06:00, Anoob Joseph:
> From: Sucharitha Sarananaga <ssarananaga@marvell.com>
> 
> Test vectors for AES-GCM need to be populated by using aead member
> and not cipher_auth. Using incorrect member would result in failures
> when AES-GCM with non-zero AAD is tried.
> 
> Bugzilla ID: 360
> Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27  5:00 [dpdk-dev] [PATCH] examples/fips_validation: fix incorrect structure used for AES-GCM Anoob Joseph
2019-11-28 15:12 ` Thomas Monjalon

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox