From: Thomas Monjalon <thomas@monjalon.net>
To: "Matthew McGovern (LINUX)" <Matthew.Mcgovern@microsoft.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [EXTERNAL] Re: [PATCH] examples/symmetric_mp: log/ignore promiscuous fail
Date: Wed, 03 Sep 2025 17:24:42 +0200 [thread overview]
Message-ID: <2049297.2IRrRt1zHL@thomas> (raw)
In-Reply-To: <IA4PR21MB54098AB9BBC8C4CAEE51148B9001A@IA4PR21MB5409.namprd21.prod.outlook.com>
03/09/2025 17:09, Matthew McGovern (LINUX):
> No reason other than to keep the patch small. I'll add some additional patches for the other apps.
>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, July 9, 2025 7:30 AM
> To: Matthew McGovern (LINUX) <Matthew.Mcgovern@microsoft.com>
> Cc: Anatoly Burakov <anatoly.burakov@intel.com>; dev@dpdk.org
> Subject: [EXTERNAL] Re: [PATCH] examples/symmetric_mp: log/ignore promiscuous fail
>
> 20/05/2025 20:37, mamcgove@microsoft.com:
> > From: Matthew G McGovern <mamcgove@microsoft.com>
> >
> > The example apps have a few different failure modes when enabling promiscuous mode:
> >
> > - testpmd will warn about the failure and continue.
> >
> > - l3fwd has a flag '-P' to explicitly require promiscuous mode.
> >
> > - symmetric_mp will exit with an error code
> >
> > This patch changes symmetric_mp to warn and continue.
>
> Why not doing the same in examples/multi_process/client_server_mp/mp_server/ ?
> What about other examples?
I think it's better making this consistent across examples.
Thank you for working on this.
prev parent reply other threads:[~2025-09-03 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 18:37 mamcgove
2025-07-09 14:29 ` Thomas Monjalon
2025-09-03 15:09 ` [EXTERNAL] " Matthew McGovern (LINUX)
2025-09-03 15:24 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2049297.2IRrRt1zHL@thomas \
--to=thomas@monjalon.net \
--cc=Matthew.Mcgovern@microsoft.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).