[PATCH] examples/symmetric_mp: log/ignore promiscuous fail

[PATCH] examples/symmetric_mp: log/ignore promiscuous fail

[mamcgove]

From: Matthew G McGovern <mamcgove@microsoft.com>

The example apps have a few different failure modes when enabling promiscuous mode:

- testpmd will warn about the failure and continue.

- l3fwd has a flag '-P' to explicitly require promiscuous mode.

- symmetric_mp will exit with an error code

This patch changes symmetric_mp to warn and continue.

Signed-off-by: Matthew G McGovern <mamcgove@microsoft.com>
---
 examples/multi_process/symmetric_mp/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c
index f7d8439cd4..974fed2cd5 100644
--- a/examples/multi_process/symmetric_mp/main.c
+++ b/examples/multi_process/symmetric_mp/main.c
@@ -275,7 +275,8 @@ smp_port_init(uint16_t port, struct rte_mempool *mbuf_pool,
 
 	retval = rte_eth_promiscuous_enable(port);
 	if (retval != 0)
-		return retval;
+		printf("Error during enabling promiscuous mode for port %u: %s - ignore\n",
+			port, rte_strerror(-retval));
 
 	retval  = rte_eth_dev_start(port);
 	if (retval < 0)
-- 
2.34.1

Re: [PATCH] examples/symmetric_mp: log/ignore promiscuous fail

[Thomas Monjalon]

20/05/2025 20:37, mamcgove@microsoft.com:
> From: Matthew G McGovern <mamcgove@microsoft.com>
> 
> The example apps have a few different failure modes when enabling promiscuous mode:
> 
> - testpmd will warn about the failure and continue.
> 
> - l3fwd has a flag '-P' to explicitly require promiscuous mode.
> 
> - symmetric_mp will exit with an error code
> 
> This patch changes symmetric_mp to warn and continue.

Why not doing the same in examples/multi_process/client_server_mp/mp_server/ ?
What about other examples?

RE: [EXTERNAL] Re: [PATCH] examples/symmetric_mp: log/ignore promiscuous fail

[Matthew McGovern (LINUX)]

No reason other than to keep the patch small. I'll add some additional patches for the other apps. 

-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Wednesday, July 9, 2025 7:30 AM
To: Matthew McGovern (LINUX) <Matthew.Mcgovern@microsoft.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>; dev@dpdk.org
Subject: [EXTERNAL] Re: [PATCH] examples/symmetric_mp: log/ignore promiscuous fail

20/05/2025 20:37, mamcgove@microsoft.com:
> From: Matthew G McGovern <mamcgove@microsoft.com>
> 
> The example apps have a few different failure modes when enabling promiscuous mode:
> 
> - testpmd will warn about the failure and continue.
> 
> - l3fwd has a flag '-P' to explicitly require promiscuous mode.
> 
> - symmetric_mp will exit with an error code
> 
> This patch changes symmetric_mp to warn and continue.

Why not doing the same in examples/multi_process/client_server_mp/mp_server/ ?
What about other examples?

Re: [EXTERNAL] Re: [PATCH] examples/symmetric_mp: log/ignore promiscuous fail

[Thomas Monjalon]

03/09/2025 17:09, Matthew McGovern (LINUX):
> No reason other than to keep the patch small. I'll add some additional patches for the other apps. 
> 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net> 
> Sent: Wednesday, July 9, 2025 7:30 AM
> To: Matthew McGovern (LINUX) <Matthew.Mcgovern@microsoft.com>
> Cc: Anatoly Burakov <anatoly.burakov@intel.com>; dev@dpdk.org
> Subject: [EXTERNAL] Re: [PATCH] examples/symmetric_mp: log/ignore promiscuous fail
> 
> 20/05/2025 20:37, mamcgove@microsoft.com:
> > From: Matthew G McGovern <mamcgove@microsoft.com>
> > 
> > The example apps have a few different failure modes when enabling promiscuous mode:
> > 
> > - testpmd will warn about the failure and continue.
> > 
> > - l3fwd has a flag '-P' to explicitly require promiscuous mode.
> > 
> > - symmetric_mp will exit with an error code
> > 
> > This patch changes symmetric_mp to warn and continue.
> 
> Why not doing the same in examples/multi_process/client_server_mp/mp_server/ ?
> What about other examples?

I think it's better making this consistent across examples.
Thank you for working on this.