From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id DF65F1B6A3 for ; Sat, 4 Nov 2017 00:03:35 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 52BFF2112E; Fri, 3 Nov 2017 19:03:34 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 03 Nov 2017 19:03:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=eVydur6EOy/YzRMtGYor7GMWNk Zj37TAhZhNuBnMFCY=; b=Jt1y1hNwuIldwjVt90JA2KLzV61Dak3xNrnSwCOyFc AQZOHRYTRs4jFZoJ/rI04sj2vld/vt3ryPJ2YdYY8/azt61LBkr+rdRNXyT23011 L0jTiTbjmvn555+IJQFIiR26NU6XwCPjG/f02etGMDQVmJn97pg/V2dOEETvvU7U o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=eVydur 6EOy/YzRMtGYor7GMWNkZj37TAhZhNuBnMFCY=; b=aIhsNvrzIJucOTskCGIhM9 cAX8qXvJfvZqwlaiptfoaZYmwVwvfq9pjr2EJKxdXYW2eO2BEHqddq5VmMQXm65v //1UAUrAlHtl69YrlFSl3l+6qhdrJ/f+VQbVuz08Q3cjCgTCACkqovRufCwSXOTO xe1+QhXpiQ6QMdHo8boRTaMKyMpLJaEeL9kHMB+RRBm0qWWotbCM/mgw0S1Kxjm5 W0KjQGX/PEyIBXDWs9c0BXFgS4FKc9pq3WMP//QYqtT3GPBW5TGLf1w23FASxFUG E/OqbyJEKlbr4oqJsqSHe09lqpYQdnmdCzX6luAizhnUnfIxxwAwmCBRq6LlkptQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0373E7E3E0; Fri, 3 Nov 2017 19:03:34 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Jianfeng Tan , Jingjing Wu , Shijith Thotton , Gregory Etelson , Harish Patil , George Prekas , Sergio Gonzalez Monroy , Rasesh Mody , Lee Roberts Date: Sat, 04 Nov 2017 00:03:32 +0100 Message-ID: <2051591.HpGYabZJN9@xps> In-Reply-To: <20171103223822.28852-1-ferruh.yigit@intel.com> References: <20171103223822.28852-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] igb_uio: prevent reset for a list of devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 23:03:36 -0000 03/11/2017 23:38, Ferruh Yigit: > Some devices are having problem on device reset that happens during DPDK > application exit [1]. > > Create a static list of devices and exclude them from device reset. [...] > This is alternative approach to > http://dpdk.org/dev/patchwork/patch/31144/ It is better to change the behaviour only for the misbehaving device, as it is done with this alternative. However as far as I understand, the change is removing a long delay due to the reset, but re-enable a security hole due to the lack of reset. So I think we must have a compilation option anyway, in order to let the packager (or distribution) make this difficult decision. The compilation option could be something like RTE_BNX2X_PREFER_SECURITY_HOLE_THAN_LONG_RESTART Feel free to find a better name :)