From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B54DA10A3 for ; Sat, 27 Oct 2018 01:46:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 46D4121D33; Fri, 26 Oct 2018 19:46:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 26 Oct 2018 19:46:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rYEbXakp4T2Gfn6u0a/yuOIeSDi6LqMLfID0/K6Se5U=; b=U5h7itHxatPd SyuZ7DdQNjh8HjVpeD3h4JC5UI3I0AUMaJAhMH44SxrKSWoCk5euNKmq1Ja9lxiO 0jeFH0sIO43XeDbKBBsdUyyxOWMlvGrp7tzTe/M8lpENmY3u21yrM3kcGtgF+Bt2 bzqfcUo/t5/EfvjwlI3pYCIdKKbYOgQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=rYEbXakp4T2Gfn6u0a/yuOIeSDi6LqMLfID0/K6Se 5U=; b=KwVsSKN8+oMxAbyfyKWay923l+gvU8dlqeIkDjhVUdnrUst6noWE2ZBKr COHOaShVQbARCPsA3h7w/K3FtCQN0yJu8yjaVlwx1eJcZVUvhB5682KLzCQaxhkf x2BF8lIXU6yemr9l6oq5kIRpTSw/vdUzP/tuHc/4uMBH6uzD1ELc3RvVwAZqYBIw J1R97Hx1/812dp0eIH0O6njpD7UfiYurBAgndjhzoow09ioT1oSViKQNSGlDusGz QSJMbaXK48wOOmv9KrEwqBBfGCvpZ8vwZwYFrWCikgr2+XNS9U7IWhXbvczPFI5D otRx1raRf6ytyk7bz3OeB9LWRKgEw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7B802102F0; Fri, 26 Oct 2018 19:46:55 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Sat, 27 Oct 2018 01:47:01 +0200 Message-ID: <2054335.yDqyzkpi5h@xps> In-Reply-To: <20181027003815.943-1-ferruh.yigit@intel.com> References: <20181026184248.78908-1-ferruh.yigit@intel.com> <20181027003815.943-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] buildtools: fix build for some mktemp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 23:46:57 -0000 27/10/2018 02:38, Ferruh Yigit: > build error: > == Build drivers/net/tap > mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c: > Invalid argument > .../buildtools/auto-config-h.sh: line 86: : No such file or directory > .../drivers/net/tap/Makefile:55: recipe for target > 'tap_autoconf.h.new' failed > > Above error observed on Wind River Linux 8.0 > > `mktemp` command in that system has a restrictions to have X in > the template at the end and at least six of them. > > Complied to mktemp requirements and add -xc flag to compiler to say > `temp` file is a C file > > Fixes: ff37ca5d3773 ("devtools: use a common prefix for temporary files") > > Reported-by: Shuai Zhu > Signed-off-by: Ferruh Yigit > --- > v2: > * keep using mktemp, add -xc to compiler > --- > buildtools/auto-config-h.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/buildtools/auto-config-h.sh > +++ b/buildtools/auto-config-h.sh > -temp=$(mktemp -t dpdk.${0##*/}.XXX.c) > +temp=$(mktemp -t dpdk.${0##*/}.c.XXXXXX) It looks OK for this script. Should we do the same kind of change for devtools/check-includes.sh? and devtools/cocci.sh?