From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, declan.doherty@intel.com, deepak.k.jain@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 1/3] kasumi: add new KASUMI PMD
Date: Mon, 20 Jun 2016 21:48:18 +0200 [thread overview]
Message-ID: <2058377.0QnmeqL1dd@xps13> (raw)
In-Reply-To: <1466433606-27398-2-git-send-email-pablo.de.lara.guarch@intel.com>
As for other crypto drivers with a dependency, I'm not sure the PMD.so
can be loaded.
2016-06-20 15:40, Pablo de Lara:
> --- /dev/null
> +++ b/drivers/crypto/kasumi/Makefile
> +# external library include paths
> +CFLAGS += -I$(LIBSSO_KASUMI_PATH)
> +CFLAGS += -I$(LIBSSO_KASUMI_PATH)/include
> +CFLAGS += -I$(LIBSSO_KASUMI_PATH)/build
The library kasumi is not linked in the PMD here.
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -134,6 +134,8 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += -lrte_pmd_null_crypto
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += -lrte_pmd_qat -lcrypto
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SNOW3G) += -lrte_pmd_snow3g
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SNOW3G) += -L$(LIBSSO_PATH)/build -lsso
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_KASUMI) += -lrte_pmd_kasumi
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_KASUMI) += -L$(LIBSSO_KASUMI_PATH)/build -lsso_kasumi
> endif # CONFIG_RTE_LIBRTE_CRYPTODEV
>
> endif # !CONFIG_RTE_BUILD_SHARED_LIBS
The dependency is linked only with the application in the static case.
I think it is a common problem to several drivers.
I suggest to fix it in a separate patchset.
next prev parent reply other threads:[~2016-06-20 19:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1462541340-11839-1-git-send-email-pablo.de.lara.guarch@intel.com>
2016-06-17 10:32 ` [dpdk-dev] [PATCH v2 0/3] Add new KASUMI SW PMD Pablo de Lara
2016-06-17 10:32 ` [dpdk-dev] [PATCH v2 1/3] kasumi: add new KASUMI PMD Pablo de Lara
2016-06-17 10:32 ` [dpdk-dev] [PATCH v2 2/3] test: add new buffer comparison macros Pablo de Lara
2016-06-17 10:32 ` [dpdk-dev] [PATCH v2 3/3] test: add unit tests for KASUMI PMD Pablo de Lara
2016-06-17 13:39 ` [dpdk-dev] [PATCH v2 0/3] Add new KASUMI SW PMD Jain, Deepak K
2016-06-20 14:40 ` [dpdk-dev] [PATCH v3 " Pablo de Lara
2016-06-20 14:40 ` [dpdk-dev] [PATCH v3 1/3] kasumi: add new KASUMI PMD Pablo de Lara
2016-06-20 19:19 ` Thomas Monjalon
2016-06-20 19:48 ` Thomas Monjalon [this message]
2016-06-23 7:37 ` Chen, Zhaoyan
2016-07-06 11:26 ` Ferruh Yigit
2016-07-06 13:07 ` Thomas Monjalon
2016-07-06 13:22 ` De Lara Guarch, Pablo
2016-06-20 14:40 ` [dpdk-dev] [PATCH v3 2/3] test: add new buffer comparison macros Pablo de Lara
2016-06-20 14:40 ` [dpdk-dev] [PATCH v3 3/3] test: add unit tests for KASUMI PMD Pablo de Lara
2016-06-20 19:58 ` [dpdk-dev] [PATCH v3 0/3] Add new KASUMI SW PMD Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2058377.0QnmeqL1dd@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=declan.doherty@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).