From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id AF4D85686 for ; Wed, 21 Sep 2016 21:37:10 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id b130so109762769wmc.0 for ; Wed, 21 Sep 2016 12:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ju1repmkHO/hHiTbLmPuf+fIRMHrwFg5DK2kE0fGEU=; b=TsYXrL/xQlVr530OR3ibK92V2OWdc7xJRvxbILDPNYszGPJdyNqcpz6Bfb9pDTysnu e6y9YKr5S2VO8XHuxzEtmpxHbYn1H2wNGzt6TWbA+pycnbtplz/D6wR4GbgzrxvWaEKn 8SnU3b38MT4+iU+TMa1Y5SJGR7YDtfkLsKeL4pM8pgzpx5rsz20l9FkRQs0DqK0VlOSL ILtZxo+1QP+4N1W6JCfw+c5DFweq96VqQaoRjXUdNNSgYe2B1lRkj3bb4PKCghU0eTba GjpOxRe8IdF4OTc1s6tx/Cr0plB/O28YhVDcZYoU/nFJV0hXTbPhRRDfq3flzW/h1BDq 4sCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=0ju1repmkHO/hHiTbLmPuf+fIRMHrwFg5DK2kE0fGEU=; b=KElNf29v8LNHmBProiXVC9K+tbBNSO2FKeTqCUE1wCYkUOGEy7awmwKH/Ruatf+wEl cfZNi1zothiUfIpZNLiy417cI7SY67ZQSCZPBTKDDAUUMEUNCIe/QqlImbe4JSlsXVva XiwuQRr293va3Wic8QNr/9AHM6bbos9rDaybE5NpOm28JFGKPhElSRS57U54ntI2N0qh r5rO9Sv5bLQX0t/WkiIQWIBRg/soSAuWAdPDxFeA81B7p0PcdOxGL5PA0dgtMzZfA9dM tJLqU0aZUO72XaC+h/nnBfjoQh+5QVXnVJGOTQ84/hwuygGXm3MdM8HwRozWvfNZYp3g 0K1g== X-Gm-Message-State: AE9vXwOnTf5Ye2WfYibIHpH7Zk16m3LLRplyDnOsbGOoy6KdIY3o/F/UrO8YJNwh3uja5Fw1 X-Received: by 10.28.25.71 with SMTP id 68mr4538788wmz.91.1474486630501; Wed, 21 Sep 2016 12:37:10 -0700 (PDT) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by smtp.gmail.com with ESMTPSA id lj2sm34974961wjc.38.2016.09.21.12.37.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Sep 2016 12:37:09 -0700 (PDT) From: Thomas Monjalon To: Matthew Hall , Nikita Kozlov Cc: dev@dpdk.org Date: Wed, 21 Sep 2016 21:37:08 +0200 Message-ID: <2058475.LZrEOEsCyO@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160921172905.GA7158@mhcomputing.net> References: <3263960.cPWMKkvuZx@xps13> <20160921172905.GA7158@mhcomputing.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] LPM6 next hop size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 19:37:10 -0000 2016-09-21 10:29, Matthew Hall: > On Tue, Sep 20, 2016 at 10:11:04PM +0200, Thomas Monjalon wrote: > > Please, will you help reviewing this patch? > > Sure. > > 1. It adds a dependency on libbsd on Linux: bsd/sys/tree.h. Is this an > expected dependency of DPDK already? I use it in my code but not sure it's > expected for everybody else. No we don't use libbsd yet. Is there a clean way to avoid this new dependency? What are the pros/cons? [...] > 7. Some of us previous submitted code to expand LPM4 and LPM6 to 24 bit next > hop but the current code is only doing 16 bit. This is not pleasant for me > because I really need the 24-bit support. When can we make this happen? It will happen as soon as a patch is approved. Matthew, what happened to your own patch for 24-bit hop? Please do not hesitate to work together if it can accelerate landing this feature.