From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8743A374
 for <dev@dpdk.org>; Tue, 27 Jun 2017 01:31:01 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id BB6A220730;
 Mon, 26 Jun 2017 19:31:00 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Mon, 26 Jun 2017 19:31:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=A2Qu9Ve8O1CwX5n
 jjGrftWc0wHwPi5NJsBhL7ERRAZo=; b=k5Cy7NPz9nA1c/MWmoHFIPXAY9rrj/S
 9JtCeRP8sY8yVMnZWZmB4UMJjQqKgj+Us0IadQIwvdWqT+zrKQ84ooh5FICkFCQv
 wHQan0r6CFglsgPxuaCi8+8AgU5Ld/oUWspmOEqe4Eew+jkWsEqcdrcbu/qYx2oL
 BiMFUnJO5Yc8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=A2Qu9Ve8O1CwX5njjGrftWc0wHwPi5NJsBhL7ERRAZo=; b=gjVopl1U
 4wcMjx99yhhr0wHi19xZcwR7ZgJd1H9T3FX8sB11/wYACSpoqqpD4DWfuVSium4/
 4qq+IS49NpunHQRJz/lbx5TK7INC65UHfQ4d252cSvFBkK7C07f6FGc3zwarh4ZO
 vtW/VkCWVpMRwgFXC459PEZNgbd/NHu97qkW1kR7wE8K06/gs/BtRx1Ek+b00Q81
 TRlhy6TjgS0TtMPxNpvlZvqgVi3eZ1407tdyY8w8iwK4uI4ZolBkpbv607P8E8YB
 wfN+UkeHKjgZpduB3u5jTJfWSiahN6FiY+4ZBvg6shIGuT3VRegO0fJwllL/7CEx
 aMVW8T7zaRbIPg==
X-ME-Sender: <xms:NJlRWcEtPTqG5OfKxm8J5EbrvKdVfpR-UWRS4kRjxXRUwbOFtXl5QQ>
X-Sasl-enc: 1NknRVJBsa4nfrMKKj5iriQOg/fQSVYetmUpRAO8bYVm 1498519860
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 71AB87E7E6;
 Mon, 26 Jun 2017 19:31:00 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Declan Doherty <declan.doherty@intel.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org
Date: Tue, 27 Jun 2017 01:30:59 +0200
Message-ID: <2058861.mNNx7DgSpj@xps>
In-Reply-To: <cee64926-19a6-c27b-14cd-6594040cced2@intel.com>
References: <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <20170621062826.21896-7-pablo.de.lara.guarch@intel.com>
 <cee64926-19a6-c27b-14cd-6594040cced2@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a
	separate file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Jun 2017 23:31:01 -0000

23/06/2017 14:52, Declan Doherty:
> On 21/06/2017 7:28 AM, Pablo de Lara wrote:
> > Move all functions handling virtual devices to a separate
> > header file "rte_cryptodev_vdev.h", in order to leave only
> > generic functions for any device in the rest of the files.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> Acked-by: Declan Doherty <declan.doherty@intel.com>

This patch is moving some code from a .c to a .h.
The consequence is that driver are now compiling new functions
from the .h and require librte_kvargs to link with.
It is a build error in shared lib mode.

Please keep the code in a .c file if possible.