From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 6CFA1271 for ; Thu, 6 Jul 2017 19:27:20 +0200 (CEST) Received: by mail-wr0-f179.google.com with SMTP id k67so11932064wrc.2 for ; Thu, 06 Jul 2017 10:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weka.io; s=google; h=from:to:cc:subject:date:message-id:organization:in-reply-to :references:mime-version:content-transfer-encoding; bh=xtZUYOScnXliRfKKO/vJYLi5H9ghMqEdYjnrRhWa9tY=; b=WipLDdC/zkabwDECyKav0DtwsmWjjIw4nWqm0u/EbZwN2b1VHQut+J9WqOjotmKtHg oOUH+4QmddPSXUhBmJLPkc60upx/1XPvWEc194hgspwSEAObKpLBjtxWtt29Qghm+yMc /WtAs4j+LX8jekKQgWCHA1SIBZv2oACM+wrNk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :in-reply-to:references:mime-version:content-transfer-encoding; bh=xtZUYOScnXliRfKKO/vJYLi5H9ghMqEdYjnrRhWa9tY=; b=QPy1L+9wfOdNRxRvKE1MYwSXjYTuWVZgNro6guWCLVbNoR4ew66pQmnGLiewpaD3N/ FK5vJ4ZMBemXjgoQlJ9xnMXXeIWcKlwSeXNqdTsIu6iaoWlMA8yXaU/zTmZL3B8D+Xac 7+D7PFV256numkDsADwfiVHw/Z8pBqH+lusrn8OZ4cn8YFEvbT7zD2nkntBTcRx/Vcf0 7agAXKYdxpJmTDgLXPy06n/5W6gGkcu84vnRuMMPFKnMut8NLAjXXvZmXTcVkFJHf7Va L6n64prj1sYgMTgktRjA7SkybGgEl6ddubHehUCYSZl5lxDgGkVB9rP/j0ifXbLZoDfQ k2zQ== X-Gm-Message-State: AIVw1135NFnW4xg2FEn3kVWS8Czx+Is9WfMlXCZeb0N9dTf5GO2oBY4u V/3SNaEkt1/ChMzq X-Received: by 10.28.199.200 with SMTP id x191mr191114wmf.94.1499362039687; Thu, 06 Jul 2017 10:27:19 -0700 (PDT) Received: from polaris.localnet (bzq-84-109-69-99.red.bezeqint.net. [84.109.69.99]) by smtp.gmail.com with ESMTPSA id u62sm818523wmd.5.2017.07.06.10.27.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jul 2017 10:27:18 -0700 (PDT) From: Gregory Etelson To: Ferruh Yigit Cc: Shijith Thotton , dev@dpdk.org, Stephen Hemminger , Qi Zhang , Wenzhuo Lu , Thomas Monjalon , Jianfeng Tan Date: Thu, 06 Jul 2017 20:27:17 +0300 Message-ID: <2058901.cGOP7o7VZP@polaris> Organization: Weka.IO In-Reply-To: References: <1496228966-18573-1-git-send-email-shijith.thotton@caviumnetworks.com> <1497260285-27536-1-git-send-email-shijith.thotton@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] igb_uio: issue FLR during open and release of device file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2017 17:27:20 -0000 I could not reproduce server crash with http://dpdk.org/dev/patchwork/patch/25267/ [1] However, pci_try_reset_function() API used in that patch is not defined in RedHat-6.x Linux-2.6.32 kernels Therefore I work with http://dpdk.org/dev/patchwork/patch/25061/ patch [2]. [2] was successfully tested with IXGBE & I40e VFs on RH 6.x, RH 7.x Ubuntu 14.04 and SLES-11.4 Regards, Gregory On Thursday, 6 July 2017 19:41:40 IDT Ferruh Yigit wrote: > On 6/12/2017 10:38 AM, Shijith Thotton wrote: > > Set UIO info device file operations open and release. Call pci reset > > function inside open and release to clear device state at start and end. > > Copied this behaviour from vfio_pci kernel module code. With this patch, > > it is not mandatory to issue FLR by PMD's during init and close. > > > > Bus master enable and disable are added in open and release respectively > > to take care of device DMA. > > > > Signed-off-by: Shijith Thotton > > This patch, and Gregory's patch [1] are very similar and main target is > to leave device in a more proper state when DPDK application quits > unexpectedly. > > Difference between two are, this one implements both .open and .release > ops, and sets / clears bus master accordingly. > > Although main concern is .reset, I am OK to follow vfio_pci approach > here, and clearing bus master on .reset can prevent unwanted DMA access. > > So, I am for this patch and I am testing it for a few days without a > problem. > > But Gregory reported a crash with older version of this patch, without > more detail, we should clear that first. With Gregory's Tested-by, I am > OK with this patch. > > > Gregory, > > Are you using your version, what are the results? And would you mind > testing this patch? > > Thanks, > ferruh > > > [1] > http://dpdk.org/dev/patchwork/patch/25061/ > >