From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48BBAA00C5; Thu, 27 Oct 2022 09:34:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D578240E50; Thu, 27 Oct 2022 09:34:23 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 66A2C40A7E for ; Thu, 27 Oct 2022 09:34:22 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A7E8D5C00D5; Thu, 27 Oct 2022 03:34:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 27 Oct 2022 03:34:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666856061; x= 1666942461; bh=rnTTyk0/IuMqqSaxl9wopp4k93XmBmaJz9D15I2NhD0=; b=h szpJET1QNRwcTAndhhyGDPguOkO+0INMelzggpJrrqIasRkgr+TW+/xs1JJ3iGaU IU850SS3Y38sAhCMTJkSjv8WttGVwnsMNLeyMuTa70N8DNbR5BFLa74fJ6UV7ByL 4vfOlNSwLB4hEP58/8Ytk5l/B/OyXmU83cMCPSMBZrJrY9fJIJPrPHXZsXHxecqC wBXi3X42L6qlzGFIoqnoak7dm72FnD/4tRVC9KCPyovtXukquW5VT4Zivx4kEzuf ojZrjs+KfSJkdCzuJ4JKmjVKfNUEvNJxIaDVa+ENa1jBETkB225uksEHmI6eTTkP d31hmDEk76YcS7I5cm5hw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666856061; x= 1666942461; bh=rnTTyk0/IuMqqSaxl9wopp4k93XmBmaJz9D15I2NhD0=; b=f xU3182AU0BsYsfCa3u7gu0o4hEWIhDkVjakhuG+S0VyR965noQWRPmuKXM9Bn55a NXPCdaZt+Z0RleDyFJm9yz/sku2X4Jafz/eSylmQTcuUN3Lx4ip+KdYao1ATxIlE 3wNCao4oGs8JS6ZJA4kEhNsBwKOVF+6v6evuip4jekv/8wSp/lSgFH37R/R1KndZ qRZfWOqaG1+O+7GwdJrNXj4M0gHjUT4mvgGeeY0p/z+Z8hGaNlsGmsnUtUMCgGZN h/Hcwf5x83GwYnOx1H1TS6nQXFUYazaED9lox8nsri95Kw7iHO30k8q+XgB/Bqle Sm+GU2GmGCzueLm+2Dn3A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdefgdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Oct 2022 03:34:20 -0400 (EDT) From: Thomas Monjalon To: Hanumanth Pothula Cc: Aman Singh , Yuying Zhang , dev@dpdk.org, jerinj@marvell.com, ndabilpuram@marvell.com, Andrew Rybchenko , rasland@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com Subject: Re: [PATCH v3 1/1] app/testpmd: control passing Rx metadata to PMD Date: Thu, 27 Oct 2022 09:34:18 +0200 Message-ID: <2059269.bB369e8A3T@thomas> In-Reply-To: <1ab79c80-ed69-8a18-5742-0039e10faecf@oktetlabs.ru> References: <20220802175151.2277437-1-hpothula@marvell.com> <20221006183522.1330826-1-hpothula@marvell.com> <1ab79c80-ed69-8a18-5742-0039e10faecf@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/10/2022 10:32, Andrew Rybchenko: > On 10/6/22 21:35, Hanumanth Pothula wrote: > > Presently, Rx metadata is sent to PMD by default, leading > > to a performance drop as processing for the same in rx path > > takes extra cycles. > >=20 > > Hence, introducing command line argument, 'nic-to-pmd-rx-metadata' > > to control passing rx metadata to PMD. By default it=E2=80=99s disabled. > >=20 > > Signed-off-by: Hanumanth Pothula >=20 > Acked-by: Andrew Rybchenko >=20 > Applied to dpdk-next-net/main, thanks. I'm not sure this patch is really acceptable. It is disabling Rx metadata by default just for benchmarking reason because your driver is doing some processing even if metadata is not requir= ed. =46rom a user perspective, if a command requesting metadata is entered, it won't work until we enable this new option on startup. It looks terrible. Please tell me I misunderstood something.