From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 631372BF3 for ; Thu, 16 Mar 2017 17:03:33 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id n11so115887382wma.1 for ; Thu, 16 Mar 2017 09:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Rezw/Y3cB0HOUI8yI4McaD2YeqUIncoktEvYkwlut2s=; b=HcuC0nrYEp8/+vJ3W0z1SXjGdDcMxFfbKq0cPd6QA57kMp5Gaje2PVsW/Jj5AxWr1m B4lJia7tXaLLiJ/rnmzvJKmM0esCjsMvc/sQNhtnUUZseduJcSjmQwy/J6jKKZFDPkZc nBxsCciLwy/MyLtP2umyeBji331p5Mtvfl21a32j4riUjN2wYZTjfOXsb/fku/I+bDpG LYRcgiiam17T2G9b7/wVQyz968f2nGdQX0jBIJHcX7ch0EZJ+FPiJmagtignbUsqPbxG g8W2aYPl0601E4GkkK9AXKYwdtwcnrjxeZDOO+k9SQOW/bG8yQYONwuuknR/WKnw1crJ ROzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Rezw/Y3cB0HOUI8yI4McaD2YeqUIncoktEvYkwlut2s=; b=kIzflwfoXNNM5JcBMpndPmS2gzD4YidjpH5V75cR4spnCHEc/rBiaf1xjAxdIi5dMP ZwyQU3reSAscBFuuvFxCE7cV/DWkLnuXpSeGzO3WGo1LUeBJ+Ap3es5H5l30O61y1nd/ Zrfy4eg5gGFTH2VaQyDMnloNkO7hM3owrelimmyO6eEZG8racDlAbAOiYul76nM9ztWX ZXc4Nw87EyhDJVB5O9KBJmbxZuUY23ey0C0NSX/f5dOpI7+hKJD8iEvEdRHDLMACfcmU EoojwlnqWImFtpzGSREmtiIpABoqTYhXZtqMVtVx88Apdb8O3Acmb3usCdDjU5NlaKsF Id6Q== X-Gm-Message-State: AFeK/H0Ol3U0glMMMQAaWAvEAW3em6yQN2beBcme9yN600yauqbIyW8Vl5917bWcUlnVlnug X-Received: by 10.28.97.194 with SMTP id v185mr9821357wmb.117.1489680212905; Thu, 16 Mar 2017 09:03:32 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id h3sm6696909wrb.6.2017.03.16.09.03.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Mar 2017 09:03:31 -0700 (PDT) From: Thomas Monjalon To: Qi Zhang , techboard@dpdk.org Cc: dev@dpdk.org, jingjing.wu@intel.com, helin.zhang@intel.com, ferruh.yigit@intel.com Date: Thu, 16 Mar 2017 17:03:31 +0100 Message-ID: <2062537.uIRGRt8aVp@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1487874421-11934-1-git-send-email-qi.z.zhang@intel.com> References: <1487874421-11934-1-git-send-email-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/i40e: enable statistic reset for VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2017 16:03:33 -0000 2017-02-23 13:27, Qi Zhang: > static void > +i40evf_dev_stats_reset(struct rte_eth_dev *dev) > +{ > + struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); > + /* only DPDK PF support this */ > + if (vf->version_major == I40E_DPDK_VERSION_MAJOR) { > + if (i40evf_reset_statistics(dev)) > + PMD_DRV_LOG(ERR, "Reset statistics failed"); > + } > +} One more SR-IOV feature not supported with a Linux PF. The basic stats feature must be marked as partially supported in doc/guides/nics/features/i40e_vf.ini See also this email: http://dpdk.org/ml/archives/dev/2017-March/060063.html I wonder whether we should allow such divergence between PF implementations. Intel committed to avoid such fragmentation and keep the SR-IOV messaging standard but it does not happen. It is said that we must allow fast innovation in DPDK space. I agree but we should also target a good usability of the VF drivers, allowing to replace the PF implementations as needed. Here is my suggestion: let's accept a VF feature only if the PF support is submitted to both dpdk.org and kernel.org mailing lists. I ask to add this topic to the next techboard meeting.