DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] qede: add missing external dependency and disable by default
@ 2016-05-24 10:28 Panu Matilainen
  2016-05-24 14:15 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Panu Matilainen @ 2016-05-24 10:28 UTC (permalink / raw)
  To: dev; +Cc: rasesh.mody, harish.patil, sony.chacko

The qede driver depends on libz but the LDLIBS entry in makefile
was missing. Also because of the external dependency, make it
disabled in default config as per common DPDK policy on external deps.

Fixes: ec94dbc57362 ("qede: add base driver")

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 config/common_base        | 2 +-
 drivers/net/qede/Makefile | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/config/common_base b/config/common_base
index 3535c6e..47c26f6 100644
--- a/config/common_base
+++ b/config/common_base
@@ -299,7 +299,7 @@ CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=n
 
 # QLogic 25G/40G PMD
 #
-CONFIG_RTE_LIBRTE_QEDE_PMD=y
+CONFIG_RTE_LIBRTE_QEDE_PMD=n
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_INIT=n
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRV=n
diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index 4cc9ee8..c9b3b1c 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -14,6 +14,8 @@ LIB = librte_pmd_qede.a
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 
+LDLIBS += -lz
+
 EXPORT_MAP := rte_pmd_qede_version.map
 
 LIBABIVER := 1
-- 
2.5.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-24 14:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-24 10:28 [dpdk-dev] [PATCH] qede: add missing external dependency and disable by default Panu Matilainen
2016-05-24 14:15 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).