From: Thomas Monjalon <thomas@monjalon.net>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: dev@dpdk.org, Heetae Ahn <heetae82.ahn@samsung.com>,
Ravi Kerur <rkerur@gmail.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: keep port_id unchanged if obtaining by name failed
Date: Fri, 09 Jun 2017 18:34:44 +0200 [thread overview]
Message-ID: <2063900.e1OC17koPI@xps> (raw)
In-Reply-To: <1495109980-3236-1-git-send-email-i.maximets@samsung.com>
18/05/2017 14:19, Ilya Maximets:
> Currently, 'rte_eth_dev_get_port_by_name' changes transmitted
> 'port_id' unconditionally. This is undocumented and misleading
> behaviour as user may expect unchanged value in case of error.
>
> Otherwise, there is no sense having both return value and
> a pointer in the function.
>
> Fixes: 9c5b8d8b9feb ("ethdev: clean port id retrieval when attaching")
>
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Applied, thanks
prev parent reply other threads:[~2017-06-09 16:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170518121955eucas1p211ce46317d0d74c99db0b94c1662fb59@eucas1p2.samsung.com>
2017-05-18 12:19 ` Ilya Maximets
2017-06-09 16:34 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2063900.e1OC17koPI@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=heetae82.ahn@samsung.com \
--cc=i.maximets@samsung.com \
--cc=rkerur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).