From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BBDE6397D for ; Fri, 9 Jun 2017 18:34:45 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5B24020A74; Fri, 9 Jun 2017 12:34:45 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 09 Jun 2017 12:34:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=k6lmaKxNcHhsYi6 zi1sHbKOVKJt5WWcaQ9O/42AmJ2o=; b=n8ynJ4uq/zmWus0LjFtgYyAyjs3iPQq g/qefjYmXHRQ3zz1A5C9+vxfTTtlnnAKCv6jGNp4304wPU2qhSrhwH0uf29blsVi ijT3N1NlfqYhzXdbCoNLqyfDM5N9gyXbkTEWOGRXDbHq7oMN7jombn7g5WfvTwQB tV7AB0+oM8OA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=k6lmaKxNcHhsYi6zi1sHbKOVKJt5WWcaQ9O/42AmJ2o=; b=AdRtcEts 6wtmwsiR+wKmaI5QQ9QuJ1p4qLAZkexT/WtYpQh0XiArSrLgtd6H40lqpbUeh8QM dXysWzrHiK/hZXpmdf6fSOjT1oU9704LSVKidToqys9ue7M5xrFjw3s9gz7EOoaK sNqO0cid3lZs2dZUb4wwJWosRMJ9tAjpuz2MtFqM6jsWWefoooi5efkmiFzPeQxA P0LrPlqTQXtCIwtfwbmUsmzjq6ZXudCFykKb4wi3TbnsrrYxwjbDcz/uBccDNSUg GN6lC9RVCgCCvgMHf6i40+uz46f8DVwcdCLhRN/PF1A7C0VLiIMhE5suF9mJZni/ ZViHh7HJvrWueQ== X-ME-Sender: X-Sasl-enc: S/TOWL7VUY8KjUwRNa1hgS6Y4qzqYkmXL4t+E+ab9bem 1497026085 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 07D5624997; Fri, 9 Jun 2017 12:34:45 -0400 (EDT) From: Thomas Monjalon To: Ilya Maximets Cc: dev@dpdk.org, Heetae Ahn , Ravi Kerur Date: Fri, 09 Jun 2017 18:34:44 +0200 Message-ID: <2063900.e1OC17koPI@xps> In-Reply-To: <1495109980-3236-1-git-send-email-i.maximets@samsung.com> References: <1495109980-3236-1-git-send-email-i.maximets@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: keep port_id unchanged if obtaining by name failed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2017 16:34:46 -0000 18/05/2017 14:19, Ilya Maximets: > Currently, 'rte_eth_dev_get_port_by_name' changes transmitted > 'port_id' unconditionally. This is undocumented and misleading > behaviour as user may expect unchanged value in case of error. > > Otherwise, there is no sense having both return value and > a pointer in the function. > > Fixes: 9c5b8d8b9feb ("ethdev: clean port id retrieval when attaching") > > Signed-off-by: Ilya Maximets Applied, thanks