From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id E7E976CA1 for ; Thu, 31 Mar 2016 14:21:48 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id p65so222676550wmp.1 for ; Thu, 31 Mar 2016 05:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=+C2dJZWJedT5hM4J07V23PsWCS0wAYTzVDGXMDlo1M8=; b=Lir7gl8ZopYzITLdajkTkne/P9cqz6bGWvGcBqrD8rLTDXUV88kLTfXVlIvqnWklez vnzkUpIcN3JarMWTUG0Dk1FBJVW7KbxhToYBrB2f8KG9HC4MWHJRGZcr7yhi4jo0o0jo kUysUr53tdoPOGXdMGXozB1tApzcjxDUu1RGHNmHcvr5dM8Tq3iaPCA0vJla8fVzhHbW FtqZ+y8DJZOj9oNRxzCuJCyEry8q5qv1fTaznDpdRBd4ronxj/2UImfSpp+Wbt31habL tArIioNFL62dvP2vJgv3m7CJ8krxw4lci7yOs7CJh9COFBeSAGqOP4aDpBRXSZar7zjM PaRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=+C2dJZWJedT5hM4J07V23PsWCS0wAYTzVDGXMDlo1M8=; b=YAjV+D6g29CHsI8ql/FvbHnKFiYq8MWbaWds3EddTG2gm2fFwdNENgOxX8hAmJGyiU v4R3hEFdChybcEZxalBFYCynev19Lpl8nbLAk8HPskcbS0+DnsDcX+r6jMjyYvXJWRPt qGseYK19m5OqJGYjp9y4IkKwvFP3y6936SsPVMBRcOHkjCFLkV2IBOcYWXUyPkNaizch OlYmIUbExR6YExnhW5CjEPX8ZntoRL290XBAw/iHYZJfDB8cM6yBkVYBh7tI/XciDqYj o+uI+VuLAzpEzJCtFrQNkIP4O+rDny40diKWTO3017wVEOI4W6d4QD8grtbfXfFan38T KUWQ== X-Gm-Message-State: AD7BkJJYpaKJ/JlnvwtofQgYWxGAqgDclxvne3KuKDIZ366+BNFy5gfGbpF3UZo1z0WOaiFm X-Received: by 10.28.52.197 with SMTP id b188mr30407768wma.77.1459426908792; Thu, 31 Mar 2016 05:21:48 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id ll9sm8808515wjc.29.2016.03.31.05.21.47 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 31 Mar 2016 05:21:48 -0700 (PDT) From: Thomas Monjalon To: Pablo de Lara Cc: dev@dpdk.org, Bruce Richardson , declan.doherty@intel.com Date: Thu, 31 Mar 2016 14:19:55 +0200 Message-ID: <2064315.gYR8cJ1A1U@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160331121417.GA27312@bricha3-MOBL3> References: <1459414919-44829-1-git-send-email-pablo.de.lara.guarch@intel.com> <1459416734-54479-1-git-send-email-pablo.de.lara.guarch@intel.com> <20160331121417.GA27312@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/8] L2fwd-crypto fixes/enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2016 12:21:49 -0000 2016-03-31 13:14, Bruce Richardson: > On Thu, Mar 31, 2016 at 10:32:06AM +0100, Pablo de Lara wrote: > > This patches fixes some small issues in L2fwd-crypto > > app and also improves the app, making it more flexible > > (accepting different key sizes) > > and readable (information display improvement). > > > > Series-tested-by: Min Cao > > > > Hi, > > Just some general advice: > > When someone is acking/resporting a tested-by for a patch series it's ok to > reply to the patch 0. > > However, for subsequent versions of the patchset itself, the acks and tested-bys > should be placed on (all) the patches themselves, not in the cover letter. If > it's in the cover letter, you're forcing the applier of the patch to modify each > one individually to stick on the extra information. Yes More information about Tested-by: In general it doesn't apply to each patch. Example, here, I doubt it has to be added to the patch "add missing new line character in help". Thanks for adding the tag where relevant (by reading the test report). [...] > > Pablo de Lara (8): > > l2fwd-crypto: add missing new line character in help > > l2fwd-crypto: rename period parameter > > l2fwd-crypto: add missing string initialization > > l2fwd-crypto: fix length of random IV/AAD > > l2fwd-crypto: fix ambiguous input key size > > l2fwd-crypto: clarify key parsing in help > > l2fwd-crypto: use key-value list of supported algorithms > > l2fwd-crypto: extend crypto information