From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEE3AA32A2 for ; Thu, 24 Oct 2019 17:17:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39C9E1EB3C; Thu, 24 Oct 2019 17:17:48 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 70AA31EB37 for ; Thu, 24 Oct 2019 17:17:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ECB5721F9F; Thu, 24 Oct 2019 11:17:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 24 Oct 2019 11:17:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=P8AjRH9ndEqXVLRlmPcJkLC9I3B1ngHHiWmbnwnWLkc=; b=jhb7ZcEeDXnj xOd/q6fZJbJGSHLObjOsX5s0chllBdgmIvZEB0m2bvY/oCKbLqh3ZdtBzRws62Xc 9Ech1t6Gmav6qZWVQhv9YlY6PTG6+10H3aqcet76Ksp5o6+hGs4zPksYzhYN/a30 7U2zi7XHyv/LPyzrTQCADAwVYNIR+6o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=P8AjRH9ndEqXVLRlmPcJkLC9I3B1ngHHiWmbnwnWL kc=; b=LHvrwG8OECZ9RkWNKHjQlitSmQxNOVQ9M+0wG5bkSM2X44o9EnkDXUGuy MKugejuiGTHkmTlYD3w133Rg4LPvShKcZmjQWLD3Gc8BUYRs91+Rh8REr0k3Lgxz w3vTK7ieW/5/8b3MWs1Eb6+SK94RWIqtxcQp+cy3xxgLrN8pfFg9LpyQaebxUOng CubGZ2RSXaigFlAOUhBSrvvpuSHc6UDsJs3TrRCkzfNYG4zwm38ku2RiSmy4VaSd 1knc6ID6HmG0kKcWqaoFWh1cOThuK9EpfCl2kvtF/F1wLWZkDlTNYKAcUml8T1hd PcXPt1aJ8zPuellycwzuv1LMJTJ4g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrledugdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A259480061; Thu, 24 Oct 2019 11:17:41 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, Ori Kam , Ferruh Yigit , "jingjing.wu@intel.com" , "stephen@networkplumber.org" Date: Thu, 24 Oct 2019 17:17:40 +0200 Message-ID: <2066428.hBRGAZJfpI@xps> In-Reply-To: References: <1569479349-36962-1-git-send-email-orika@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/10/2019 16:47, Andrew Rybchenko: > On 10/24/19 11:29 AM, Ori Kam wrote: > > Hi Andrew, > > > > When writing the new function I thought about using bool, but > > I decided against it for the following reasons: > > 1. There is no use of bool any where in the code, and there is not special reason to add it now. > > rte_ethdev.c includes stdbool.h and uses bool > > > 2. Other functions of this kind already returns int. for example (rte_eth_dev_is_valid_port / rte_eth_is_valid_owner_id) I agree with Ori here for 2 reasons: 1. It is better to be consistent in the API 2. I remember having some issues with some drivers when introducing stdbool in the API. I think it may be nice to convert all such API to bool in one patch, and check if there are some remaining issues with bool usage in drivers or with PPC. But I suggest to do such API change in DPDK 20.11.