From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 92FAC1E35 for ; Thu, 25 Jan 2018 11:57:48 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 36FC621756; Thu, 25 Jan 2018 05:57:48 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 25 Jan 2018 05:57:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=3mu3BCkZ5nsVISzjDMThFmSOX7 igI6oZQFCAalAyal4=; b=FY7O/fEAT1zv55IV39dzTXSyrYCg2BgKKRZNa5VTAQ Ylzu/HGpgrT0BBRq/B5/93UGHdXRMAlfpBbSsN3mCdknYamW/em1EhOv+LDM5i4A 76vX08X2Auj+gh8oIjgR1WoHqvfq+MqW/Su7EJ2lexb1FiDfS9TbmSe47bGvGsQ7 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=3mu3BC kZ5nsVISzjDMThFmSOX7igI6oZQFCAalAyal4=; b=Q7eIIE4xAjKeu6Gl0uZfbN nadiWF59iywpG9MuWIaylGSlQZu0GJC2K2Wp+0OyniIKnz4M+pUhpKS1v+28Xz4P rwrRuqmyqfAc9U/GbFfuXXEYqwMu7oYTN3/8Yw5WnX3SS5Np8RJxFnyNVs0t/tyi 8JBVy3vK4pkJTjAV+V2koqwowwIkAkWKjtVmpqB160qXOeO8t6nTjfNrAiDMjJHX 6jMdSNgYd/s7HeOg5D08Ln+At9LBZrNBkzG4L0TJSmzeded/aDw8XACvvd6VS6zn 5g6R/S2TqBTP3AuzHAsCCN44ipVQiW35cKH/OG6BEdzNSRvc/ZLayDVk483dmDWA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D031924752; Thu, 25 Jan 2018 05:57:47 -0500 (EST) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: Jianfeng Tan , dev@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com Date: Thu, 25 Jan 2018 11:57:06 +0100 Message-ID: <2069506.YIxbetVmv7@xps> In-Reply-To: <3fe4f70a-eeb6-e061-5d2e-8b62578ced47@intel.com> References: <1512067450-59203-1-git-send-email-jianfeng.tan@intel.com> <2010166.0Q39LqRaO8@xps> <3fe4f70a-eeb6-e061-5d2e-8b62578ced47@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 3/3] vfio: use the generic multi-process channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 10:57:48 -0000 25/01/2018 11:52, Burakov, Anatoly: > On 25-Jan-18 10:47 AM, Thomas Monjalon wrote: > > 25/01/2018 05:16, Jianfeng Tan: > >> Previously, vfio uses its own private channel for the secondary > >> process to get container fd and group fd from the primary process. > >> > >> This patch changes to use the generic mp channel. > > > > There was a private request to get it in 18.02-rc2. > > > > I have 3 concerns: > > 1/ It is late > > 2/ It is not yet reviewed by Anatoly and Konstantin > > 3/ We try to not rework the existing code in RC2, > > because it would totally invalidate the validation work > > done for RC1. > > > > > > Hi Thomas, > > We can postpone the VFIO patch until 18.05, and integrate only the first > two patches. First two patches do not change anything in DPDK, so > validation impact should be non-existent. Yes, possible if it is well reviewed and all comments addressed.