From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com
 [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 90E4A5681
 for <dev@dpdk.org>; Thu, 17 Sep 2015 12:14:33 +0200 (CEST)
Received: by wiclk2 with SMTP id lk2so20668727wic.1
 for <dev@dpdk.org>; Thu, 17 Sep 2015 03:14:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=0HMj3WRFUcuZI0sIALVEbPajcEnhEx3l8bx6nTQ2obo=;
 b=kWhH38aYwjkJ/jXjHTEPNCEBO+h/78M4I8O091bN625JsW0m/RrHYTHMnSP6Mr08vW
 oYw6xoL7YUG6tiXjT6j1JTzbQIT/7zjFOhtS/Xx7AjdRtRWmUhIYR5LZyFwOaSW7m7Fa
 nj9el8apIfPIxdKH/wOtUJynY1I/ni5254VysGdDDcdYtHL9o0B5+PyDsgocXxi/b/IU
 Mw6Fwn+U47j+0tkdmcqfMP+pswDZXXBFwOzg/LaQa+lwlEtoFDlMEBsyL9tK5o+n7Ms7
 0PsNwL+ImIUtp9eoFmALpuQHi/5gUB69zqfKQLDu5+MGeJL1xGORVWw2Y1alcRhNJBOj
 BIDg==
X-Gm-Message-State: ALoCoQlNveHjB4oOMc/N5p+PHDNtdv15Agvj+JjVWKaovBU+cWFPuMJDAadC1WRLHXsbZO3UV2cQ
X-Received: by 10.194.235.6 with SMTP id ui6mr67304231wjc.92.1442484873254;
 Thu, 17 Sep 2015 03:14:33 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id d1sm9291179wiz.0.2015.09.17.03.14.32
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 17 Sep 2015 03:14:32 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Remy Horton <remy.horton@intel.com>
Date: Thu, 17 Sep 2015 12:13:23 +0200
Message-ID: <2070411.ZdUtn3z4CD@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1442480744-3393-1-git-send-email-remy.horton@intel.com>
References: <1442480744-3393-1-git-send-email-remy.horton@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix access to last byte of EEPROM
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Sep 2015 10:14:33 -0000

2015-09-17 10:05, Remy Horton:
> Incorrect operator in ixgbe_get_eeprom & ixgbe_set_eeprom prevents
> last byte of EEPROM being read/written, and hence cannot be dumped
> or updated in entirity using these functions.
> 
> Signed-off-by: Remy Horton <remy.horton@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

>>From my previous comment:
"
Then creating a commit starting with "fix" should trigger 2 other things:
        - a Fixes: tag
        - an update in the release notes (because the bug exists in previous releases)
"

Maybe it does not deserve an entry in the release notes if the bug
has no real impact.