[dpdk-dev] [PATCH] sched: remove unused debug functions

[dpdk-dev] [PATCH] sched: remove unused debug functions

[Thomas Monjalon]

clang warns about unused functions when debug is enabled.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 lib/librte_sched/rte_sched.c | 31 -------------------------------
 1 file changed, 31 deletions(-)

diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index 9f0b458..d47cfc2 100644
--- a/lib/librte_sched/rte_sched.c
+++ b/lib/librte_sched/rte_sched.c
@@ -1055,16 +1055,6 @@ rte_sched_port_queue_is_empty(struct rte_sched_port *port, uint32_t qindex)
 	return (queue->qr == queue->qw);
 }
 
-static inline int
-rte_sched_port_queue_is_full(struct rte_sched_port *port, uint32_t qindex)
-{
-	struct rte_sched_queue *queue = port->queue + qindex;
-	uint16_t qsize = rte_sched_port_qsize(port, qindex);
-	uint16_t qlen = queue->qw - queue->qr;
-
-	return (qlen >= qsize);
-}
-
 #endif /* RTE_SCHED_DEBUG */
 
 #ifdef RTE_SCHED_COLLECT_STATS
@@ -1156,27 +1146,6 @@ rte_sched_port_set_queue_empty_timestamp(struct rte_sched_port *port, uint32_t q
 
 #ifdef RTE_SCHED_DEBUG
 
-static inline int
-debug_pipe_is_empty(struct rte_sched_port *port, uint32_t pindex)
-{
-	uint32_t qindex, i;
-
-	qindex = pindex << 4;
-
-	for (i = 0; i < 16; i++) {
-		uint32_t queue_empty = rte_sched_port_queue_is_empty(port, qindex + i);
-		uint32_t bmp_bit_clear = (rte_bitmap_get(port->bmp, qindex + i) == 0);
-
-		if (queue_empty != bmp_bit_clear)
-			rte_panic("Queue status mismatch for queue %u of pipe %u\n", i, pindex);
-
-		if (!queue_empty)
-			return 0;
-	}
-
-	return 1;
-}
-
 static inline void
 debug_check_queue_slab(struct rte_sched_port *port, uint32_t bmp_pos,
 		       uint64_t bmp_slab)
-- 
2.5.2

Re: [dpdk-dev] [PATCH] sched: remove unused debug functions

[Thomas Monjalon]

2015-11-25 01:52, Thomas Monjalon:
> clang warns about unused functions when debug is enabled.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied