Re: [dpdk-dev] [PATCH] scripts: add git hook scripts for checkpatch and auto doc generation

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Thanks for the idea

2015-11-06 13:48, Ferruh Yigit:
> post-merge: Same script as "post-commit", but triggered after git pull

A symbolic link would be sufficient.
As it must be installed in the git hooks (probably making a symbolic link),
duplicating the file is not needed at all.

> pre-commit: Does a checkpatch check before commit started. If script
> finds any error it will print warnings and fails. If  checkpatch
> fails commit also fails. This guaranties every commit pass checkpatch.
> Default script is <dpdk>/scripts/checkpatch.pl but this can be
> changed by RTE_CHECKPATCH environment variable. Also a default list
> of checkpatch ignore items defined, new ones can be added by IGNORE
> environment variable.

Please use the new scripts/checkpatches.sh:
http://dpdk.org/dev/patchwork/patch/9036/

> This script can bypassed by commit "--no-verify" argument.

Could you document the --no-verify option in the script?

> Deployment:
> To make scripts active they need to be in <dpdk>/.git/hooks folder.
> Alternatively "deploy.sh" script can be used, it simply copies all
> scripts into proper folder. Script names are significant and
> shouldn't changed.

Why not using symbolic links?