From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id ECD2191A0 for ; Tue, 24 Nov 2015 18:45:54 +0100 (CET) Received: by wmuu63 with SMTP id u63so106925802wmu.0 for ; Tue, 24 Nov 2015 09:45:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=/H+yWlk9tX9lA8HwsloWpf8JZtGWuD3iLLc9mqphq5o=; b=bR1yCiNB8bS0o/Hf8BxMS/gECezWkmhl/eKv/zJTuPUHlmeQ1iwoCG6doRvlOaszGp wqqTjcc1smXFebNIoL1dHFBeBJYIXjM1+8LmjxRTdmu6KBt3cv8dsdA/hV97qT5jXZ6J 4d5iq3JAnK9b7w8afSLy49/FtnRcozvqOfv3AsSJqpucZmvKI2rgQ4+QlsXyUSTxzlHY rIe5qwRfXubWytVp7DMBnBdXzrMNXc2ebOS46weUMOTfzOh5Czxmd++xNDqbO9Rkv8NF EDYMynV9LtM0j1aVfuHFXdy3zHQBnA/3zxYYdjKpI2wIDi6zwfRcTMLQvMhvlfjiWwF9 3K/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=/H+yWlk9tX9lA8HwsloWpf8JZtGWuD3iLLc9mqphq5o=; b=kLPuPFgug03zGsfzlyKHCRhiW40/MGXtPH5Sn7o42PnuDfwF7+KwHObxSnn0qdcOpg CngB5lTwJS0ljr1r7hodyKDdGtL1Cq8pi7q54j/lv5hGY4zCMEJK/ox4WEA5kFKThVUU qUYlwCmJSrF2nhE2zqhTIodKWu6AhNdSzoLSY8hzZ7QWgPEcTyJixhRX+QYYLCJ2TaZm ajMcHmByfFfQYNRAgCmJ+MfskDhPQVkeDZH2L80XSXcbyiJPq4xe8/vFRkd4u7jRPc5I Quv3GGcIOvV4IyB4sdFRJSZjdiNzQ11KDjY4SwD/il+MpwwcpKRxrGawY5WW7ISz6A5r Bi6w== X-Gm-Message-State: ALoCoQlPYFjUkn5LLbjCxutNu7xFAmV4GljyWkXjSFfJIwnA6JNc3PFUbQAaeJ6KueMn2TYy1dWU X-Received: by 10.194.7.230 with SMTP id m6mr21759200wja.124.1448387154778; Tue, 24 Nov 2015 09:45:54 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id bg10sm19244481wjb.46.2015.11.24.09.45.53 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Nov 2015 09:45:53 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit Date: Tue, 24 Nov 2015 18:44:36 +0100 Message-ID: <2076055.LzC464LxxN@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1446817732-17873-2-git-send-email-ferruh.yigit@intel.com> References: <1446160974-31675-1-git-send-email-ferruh.yigit@intel.com> <1446817732-17873-1-git-send-email-ferruh.yigit@intel.com> <1446817732-17873-2-git-send-email-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] scripts: add git hook scripts for checkpatch and auto doc generation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2015 17:45:55 -0000 Thanks for the idea 2015-11-06 13:48, Ferruh Yigit: > post-merge: Same script as "post-commit", but triggered after git pull A symbolic link would be sufficient. As it must be installed in the git hooks (probably making a symbolic link), duplicating the file is not needed at all. > pre-commit: Does a checkpatch check before commit started. If script > finds any error it will print warnings and fails. If checkpatch > fails commit also fails. This guaranties every commit pass checkpatch. > Default script is /scripts/checkpatch.pl but this can be > changed by RTE_CHECKPATCH environment variable. Also a default list > of checkpatch ignore items defined, new ones can be added by IGNORE > environment variable. Please use the new scripts/checkpatches.sh: http://dpdk.org/dev/patchwork/patch/9036/ > This script can bypassed by commit "--no-verify" argument. Could you document the --no-verify option in the script? > Deployment: > To make scripts active they need to be in /.git/hooks folder. > Alternatively "deploy.sh" script can be used, it simply copies all > scripts into proper folder. Script names are significant and > shouldn't changed. Why not using symbolic links?