From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gregory@weka.io>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id D3EDC99C2
 for <dev@dpdk.org>; Fri, 26 May 2017 06:31:01 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id d127so6276865wmf.0
 for <dev@dpdk.org>; Thu, 25 May 2017 21:31:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weka.io; s=google;
 h=from:to:cc:subject:date:message-id:organization:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=dL0UJCokNtShWIaPLiZ40bRWpzhNTdMcYgNuzpKDeOA=;
 b=Q1DzoRk+a5mwy24UbU11q3qnPXuSBchz74s0a1ngDkRg/uetAx9/KSOZ6Vl0Blz7Aj
 QtSO6OD/kfX0DPnykseIri62hA9fDXWVGrsVSJA/VJr4nV/EBXgaJqJxyzYi/k7Otih2
 9/WQVxuSFlLjDSJLlQz7KDh4Ct9tbIpSWHTts=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=dL0UJCokNtShWIaPLiZ40bRWpzhNTdMcYgNuzpKDeOA=;
 b=dsvipLCfSidRYlZFQzKucXTtqVy8ns7Tt3w5YoDRXF01WbRG+VFPJsVyaJFlVQDanh
 FzPjmS1zjxLvZP5sOWer2VISZ5RQwlQYl8l7fU5MNC6+rVA5lSfjkRrxeatl4x9tzpDP
 Kthbqhn2IEp7zq1CRr0FLAIOQy+VePCNHLdQoRcw/op+0p6nQHxZE0U9l3XzIoDI6UWy
 zGcgVuIN8arfJpzBNOCCHiKqG2AAoLbatxdzFY0jOZG7N6DHIElUjwRpOVkE6OPmUUjC
 Y1oo/XKOhCmufqyw25DU0cHlQ6ZoDO204VSN900s7Tys41st/smuegJluVMASyvbb4PZ
 55tQ==
X-Gm-Message-State: AODbwcBf5Ol8H9MCgMkokYp83J5ELZQCzb+4vP5DXGD1oH3q6sK4G0PA
 NaLCgQZni8iwu0rk
X-Received: by 10.28.65.213 with SMTP id o204mr11218883wma.43.1495773061225;
 Thu, 25 May 2017 21:31:01 -0700 (PDT)
Received: from polaris.localnet (bzq-84-109-69-99.cablep.bezeqint.net.
 [84.109.69.99])
 by smtp.gmail.com with ESMTPSA id y6sm12588180wrc.51.2017.05.25.21.31.00
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 25 May 2017 21:31:00 -0700 (PDT)
From: Gregory Etelson <gregory@weka.io>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
 Qi Zhang <qi.z.zhang@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>
Date: Fri, 26 May 2017 07:30:58 +0300
Message-ID: <2080347.1TTqQevoe3@polaris>
Organization: Weka.IO
In-Reply-To: <20170525114242.3c6ac1b7@xeon-e3>
References: <106841857.Z7q1jSDIte@polaris> <20170525114242.3c6ac1b7@xeon-e3>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] i40e igb_uio: reset pci on process exit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 May 2017 04:31:02 -0000

Hello,

This patch introduces idea I would like to implement in igb_uio driver
However, I would like to get hardware experts confirmation.
If the procedure correct I'll submit proper patch 

Regards,
Gregory

On Thursday, 25 May 2017 21:42:42 IDT Stephen Hemminger wrote:
> On Wed, 24 May 2017 14:22:11 +0300
> Gregory Etelson <gregory@weka.io> wrote:
> 
> >  
> > +static int
> > +igbuio_pci_release(struct uio_info *info, struct inode *inode)
> > +{
> > +       int ret;
> > +       struct rte_uio_pci_dev *udev = info->priv;
> > +       struct pci_dev *dev = udev->pdev;
> > +       ret = __pci_reset_function(dev);
> > +       dev_info(&dev->dev, "pci_reset_function %s \n",
> > +                 ret == 0 ? "succeded" : "failed");
> > +       return 0;
> > +}
> > +
> > +
> 
> Patch in general looks ok, but:
>  * no Signed-off
>  * whitespace issues
>  * doesn't pass kernel coding style
>  * don't log on success, why log at all??
>