From: Thomas Monjalon <thomas@monjalon.net>
To: Nick Connolly <nick.connolly@mayadata.io>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Keith Wiles <keith.wiles@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Ranjit Menon <ranjit.menon@intel.com>,
stable@dpdk.org, dev@dpdk.org,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] windows: build error with mingw debug
Date: Mon, 07 Dec 2020 19:30:30 +0100 [thread overview]
Message-ID: <2080573.HJaM55CJaF@thomas> (raw)
In-Reply-To: <20201127110726.5328-1-nick.connolly@mayadata.io>
27/11/2020 12:07, Nick Connolly:
> Compiling with MinGW in --buildtype=debug produces a redefinition
> error for strncasecmp.
>
> The root cause is that rte_os.h shouldn't be injecting POSIX definitions
> into the environment. It is the applications responsibility to decide
> how to handle missing functionality.
>
> Resolving this properly will require further work, but in the meantime
> wrap all such definitions with #ifndef/#endif. This resolves the specific
> issue with strncasecmp and handles similar issues that applications may
> encounter.
>
> Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
Reported-by: David Marchand <david.marchand@redhat.com>
It looks as a good fix to me.
I'm surprised there was no review.
Applied, thanks
prev parent reply other threads:[~2020-12-07 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 11:07 [dpdk-dev] " Nick Connolly
2020-12-07 18:30 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2080573.HJaM55CJaF@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=keith.wiles@intel.com \
--cc=navasile@linux.microsoft.com \
--cc=nick.connolly@mayadata.io \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).