From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id D47E47EEB for ; Wed, 12 Nov 2014 00:07:07 +0100 (CET) Received: by mail-wg0-f43.google.com with SMTP id y10so12745611wgg.30 for ; Tue, 11 Nov 2014 15:16:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=siaApWf7o94UoQhhE2ClJw2Z8WTODL4JsaH1YRZ9yNk=; b=COs/QUrb2Aj5vk2xVOcKnDVGIv3xygfiFtoIQWXjg5Ee2epcey0hCH+FA3vLS2sX6T 6ukdcqN9pagOLxczmC6y02J+ScLYDX47MexODxCvlgqku8sKXiSw4gU4fh3LVJN1lvhb atccf1E+hJRDriE/JeXg/nhd+IognVIlI5DwFY63hb9S+FDmxbLyp3BiUFhXmL2DB96r dV5KhGWIIPq5W5A8RbFEOz7jyx5ZsfGM+qmgJP2g6nGbztW612N49eoLldpYSFZe1gVw HGgEk2Uk1NFQcXy9j8LA3xsQC/K5MycGfmUxMTU2/5w6XxlOZ8Jzb2A+b5cwCoj3YrER huWg== X-Gm-Message-State: ALoCoQmWvdbjE26lWlR/4M86druHql02CLGHFTViYsgrQJ/SrRaSK0vVPplj6f0yuV6ybYKOCTif X-Received: by 10.194.92.82 with SMTP id ck18mr57938887wjb.103.1415747819536; Tue, 11 Nov 2014 15:16:59 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id b6sm19317464wiy.22.2014.11.11.15.16.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Nov 2014 15:16:58 -0800 (PST) From: Thomas Monjalon To: Ouyang Changchun Date: Wed, 12 Nov 2014 00:16:41 +0100 Message-ID: <20823298.IzMeYNyBN7@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1415420776-4821-1-git-send-email-changchun.ouyang@intel.com> References: <1414732757-7241-1-git-send-email-changchun.ouyang@intel.com> <1415420776-4821-1-git-send-email-changchun.ouyang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 0/5] Support virtio multicast feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Nov 2014 23:07:08 -0000 > -V1 change: > This patch series support multicast feature in virtio and vhost. > The vhost backend enables the promiscuous mode and config ETH_VMDQ_ACCEPT_BROADCAST > and ETH_VMDQ_ACCEPT_MULTICAST in VMDQ offload register to receive the multicast and broadcast packets. > The virtio frontend provides the functionality of enabling and disabling the multicast and > promiscuous mode. > > -V2 change: > Rework the patch basing on new vhost library and new vhost application. > > -V3 change: > Rework the patch for comments, split commits. > > -V4 change: > Rework for refining code comment and patch titles, fatorizing codes, and resolving conflicts. > > Changchun Ouyang (5): > ethdev: Add vmdq rx mode > igb: Config VM offload register > ixgbe: Configure Rx mode for VMDQ > virtio: Support promiscuous and allmulticast > vhost: Enable promisc mode and multicast I reviewed only the first 3 commits. The virtio and vhost commits seem to have been reviewed by Huawei. Next times, a clear acked-by would be preferable. Please note that this is the role of developpers to request reviews when needed. Reviews are not always spontaneous :) Applied Thanks -- Thomas